linux-kernel - Re: [PATCH 5/8] firmware: imx: scu-irq: Remove unused export of imx_scu_enable_general_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO5zcO+xLvADuEtS@lizhi-Precision-Tower-5810>
Date: Tue, 14 Oct 2025 11:59:44 -0400
From: Frank Li <Frank.li@....com>
To: Peng Fan <peng.fan@....com>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Dong Aisheng <aisheng.dong@....com>, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] firmware: imx: scu-irq: Remove unused export of
 imx_scu_enable_general_irq_channel

On Tue, Oct 14, 2025 at 12:54:42PM +0800, Peng Fan wrote:
> Since its introduction, this symbol has not been used by any loadable
> modules. It remains only referenced within imx-scu.c, which is always built
> together with imx-scu-irq.c

imx_scu_enable_general_irq_channel is only referenced within imx-scu.c,
which always built together with imx-scu-irq.c.

>
> As such, exporting imx_scu_enable_general_irq_channel is unnecessary, so
> remove the export.
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---

Reviewed-by: Frank Li <Frank.Li@....com>

>  drivers/firmware/imx/imx-scu-irq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c
> index 1346b75596293892ccd90a856d46f52171d88734..0be9c4c75d826a641e7078a265d30f146e8eb14d 100644
> --- a/drivers/firmware/imx/imx-scu-irq.c
> +++ b/drivers/firmware/imx/imx-scu-irq.c
> @@ -259,4 +259,3 @@ int imx_scu_enable_general_irq_channel(struct device *dev)
>
>  	return ret;
>  }
> -EXPORT_SYMBOL(imx_scu_enable_general_irq_channel);
>
> --
> 2.37.1
>