linux-kernel - Re: [PATCH 8/8] firmware: imx: scu: Use devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aO50EheJpp57v+8K@lizhi-Precision-Tower-5810>
Date: Tue, 14 Oct 2025 12:02:26 -0400
From: Frank Li <Frank.li@....com>
To: Peng Fan <peng.fan@....com>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Dong Aisheng <aisheng.dong@....com>, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] firmware: imx: scu: Use devm_mutex_init

On Tue, Oct 14, 2025 at 12:54:45PM +0800, Peng Fan wrote:
> In normal case, there is no need to invoke mutex_destroy in error path,
> but it is useful when CONFIG_DEBUG_MUTEXES, so use devm_mutex_init().
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---

Reviewed-by: Frank Li <Frank.Li@....com>

>  drivers/firmware/imx/imx-scu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
> index 630e3dba4db15961ae4d77273af6248be614145e..67b267a7408a12deed77d2c8f52d5f64b239a408 100644
> --- a/drivers/firmware/imx/imx-scu.c
> +++ b/drivers/firmware/imx/imx-scu.c
> @@ -324,7 +324,9 @@ static int imx_scu_probe(struct platform_device *pdev)
>  	}
>
>  	sc_ipc->dev = dev;
> -	mutex_init(&sc_ipc->lock);
> +	ret = devm_mutex_init(dev, &sc_ipc->lock);
> +	if (ret)
> +		return ret;
>  	init_completion(&sc_ipc->done);
>
>  	imx_sc_ipc_handle = sc_ipc;
>
> --
> 2.37.1
>