linux-kernel - Re: [PATCH 2/8] firmware: imx: scu-irq: Free mailbox client on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251015135503.GA31091@nxa18884-linux.ap.freescale.net>
Date: Wed, 15 Oct 2025 21:55:03 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Frank Li <Frank.li@....com>
Cc: Peng Fan <peng.fan@....com>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Dong Aisheng <aisheng.dong@....com>, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] firmware: imx: scu-irq: Free mailbox client on
 failure

On Tue, Oct 14, 2025 at 11:54:36AM -0400, Frank Li wrote:
>On Tue, Oct 14, 2025 at 12:54:39PM +0800, Peng Fan wrote:
>> With mailbox channel freed, it is pointless to keep mailbox client.
>> So free the mailbox client in err path.
>>
>> Signed-off-by: Peng Fan <peng.fan@....com>
>> ---
>>  drivers/firmware/imx/imx-scu-irq.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c
>> index f2b902e95b738fae90af9cbe54da4f488219906f..1fbe4c3de5c1592bfcf2334a83776c25d5ca7a3f 100644
>> --- a/drivers/firmware/imx/imx-scu-irq.c
>> +++ b/drivers/firmware/imx/imx-scu-irq.c
>> @@ -255,6 +255,7 @@ int imx_scu_enable_general_irq_channel(struct device *dev)
>>
>>  free_ch:
>>  	mbox_free_channel(ch);
>> +	devm_kfree(dev, cl);
>
>
>you use devm_kmalloc(), when return failure, framework will auto free cl.
>
>Avoid mixing manual free and management free code.
>
>So I think this patch is not neccesary.

Actually in imx-scu.c, there is only a warning message if this API call returns
error. So need to free here.

Thanks
Peng

>
>Frank
>>
>>  	return ret;
>>  }
>>
>> --
>> 2.37.1
>>