linux-kernel - Re: [PATCH v2 3/6] arm64: dts: qcom: r0q: add touchscreen support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMQHOhe=WYhtsjHMcRnJOi8UhnNNBfveTWRGSZ_bg24gFysAEw@mail.gmail.com>
Date: Tue, 14 Oct 2025 15:04:44 -0400
From: Ghatto <ghatto404@...il.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: r0q: add touchscreen support

On Tue, Oct 14, 2025 at 11:18 AM Konrad Dybcio
<konrad.dybcio@....qualcomm.com> wrote:
>
> On 10/14/25 5:10 PM, Ghatto wrote:
> > On Tue, Oct 14, 2025 at 7:01 AM Konrad Dybcio
> > <konrad.dybcio@....qualcomm.com> wrote:
> >>
> >> On 10/14/25 6:41 AM, Eric Gonçalves wrote:
> >>> Enable the ST-Microelectronics FTS2BA61Y touchscreen. This patch
> >>> depends on "Input: add support for the STM FTS2BA61Y touchscreen".
> >>
> >> The second sentence doesn't really make sense to be included in
> >> the git log
> > I'll keep it to the cover letter then
> >>
> >>> The device has an issue where SPI 8 (the bus which the touchscreen is
> >>> connected to) is not working properly right now, so
> >>> spi-gpio is used instead.
> >>
> >> Some Samsung devices used to use spi/i2c-gpio intentionally, also
> >> on downstream. I'm assuming this isn't the case for r0q.
> > It isn't, the device uses fts2ba61y on the spi8 bus - I hosted the
> > DT at https://github.com/ghatt-o/ss_experiments/blob/main/r0q.dts if you
> > want to take a look.
> >>
> >> Did you enable gpi_dma1, qupv3_id_1 before spi8, when testing
> > The driver probes, but it fails to recognize the touchscreen device
>
> Could you post a complete dmesg and the precise DT diff you used?
https://pastebin.com/QkYa8nMp (android dmesg) mainline dmesg doesn't have
any relevant information other than spi/i2c probing, however, I've noticed
both on deviceinfohw.ru and the dmesg that for some reason the touchscreen
is on spi0.0 (even though DT says 8) and I'm not sure if that means it's on SPI
but on a bugged out bus or if it's really just spi on bus 0
@@ -85,7 +85,7 @@
         * is used instead.
         */

-       spi8 {
+       /*spi8 {
                compatible = "spi-gpio";
                pinctrl-names = "default", "sleep";
                pinctrl-0 = <&spi_clk_tsp_active &spi_mosi_tsp_active
&spi_miso_tsp_active>;
@@ -106,7 +106,6 @@
                touchscreen@0 {
                        compatible = "st,fts2ba61y";
                        reg = <0>;
-                       spi-max-frequency = <5000000>;

                        vdd-supply = <&vreg_l8c_1p8>;
                        avdd-supply = <&vreg_l11c_3p0>;
@@ -120,8 +119,7 @@

                        status = "okay";
                };
-       };
-
+       };*/

        vph_pwr: regulator-vph-pwr {
                compatible = "regulator-fixed";
@@ -134,6 +132,10 @@
        };
 };

+&gpi_dma1 {
+       status = "okay";
+};
+
 &apps_rsc {
        regulators-0 {
                compatible = "qcom,pm8350-rpmh-regulators";
@@ -280,10 +282,38 @@
        status = "okay";
 };

+&spi8 {
+       spi-max-frequency = <5000000>;
+
+       touchscreen@0 {
+               compatible = "st,fts2ba61y";
+               reg = <0>;
+
+               vdd-supply = <&vreg_l8c_1p8>;
+               avdd-supply = <&vreg_l11c_3p0>;
+
+               interrupt-parent = <&tlmm>;
+               interrupts = <46 IRQ_TYPE_LEVEL_LOW>;
+
+               pinctrl-names = "default", "sleep";
+               pinctrl-0 = <&tsp_int_active>;
+               pinctrl-1 = <&tsp_int_sleep>;
+
+               status = "okay";
+       };
+
+
+       status = "okay";
+};
+
 &qupv3_id_0 {
        status = "okay";
 };

+&qupv3_id_1 {
+       status = "okay";
+};
+
 &tlmm {
        gpio-reserved-ranges = <36 4>; /* SPI (Unused) */>
> Konrad
Resend (forgot to reply all)