linux-kernel - Re: [PATCH v2 3/6] arm64: dts: qcom: r0q: add touchscreen support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd5486f-38a9-4104-8d09-234f642b45fe@oss.qualcomm.com>
Date: Thu, 16 Oct 2025 12:06:37 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Ghatto <ghatto404@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: r0q: add touchscreen support



On 10/14/25 9:04 PM, Ghatto wrote:
> On Tue, Oct 14, 2025 at 11:18 AM Konrad Dybcio
> <konrad.dybcio@....qualcomm.com> wrote:
>>
>> On 10/14/25 5:10 PM, Ghatto wrote:
>>> On Tue, Oct 14, 2025 at 7:01 AM Konrad Dybcio
>>> <konrad.dybcio@....qualcomm.com> wrote:
>>>>
>>>> On 10/14/25 6:41 AM, Eric Gonçalves wrote:
>>>>> Enable the ST-Microelectronics FTS2BA61Y touchscreen. This patch
>>>>> depends on "Input: add support for the STM FTS2BA61Y touchscreen".
>>>>
>>>> The second sentence doesn't really make sense to be included in
>>>> the git log
>>> I'll keep it to the cover letter then
>>>>
>>>>> The device has an issue where SPI 8 (the bus which the touchscreen is
>>>>> connected to) is not working properly right now, so
>>>>> spi-gpio is used instead.
>>>>
>>>> Some Samsung devices used to use spi/i2c-gpio intentionally, also
>>>> on downstream. I'm assuming this isn't the case for r0q.
>>> It isn't, the device uses fts2ba61y on the spi8 bus - I hosted the
>>> DT at https://github.com/ghatt-o/ss_experiments/blob/main/r0q.dts if you
>>> want to take a look.
>>>>
>>>> Did you enable gpi_dma1, qupv3_id_1 before spi8, when testing
>>> The driver probes, but it fails to recognize the touchscreen device
>>
>> Could you post a complete dmesg and the precise DT diff you used?
> https://pastebin.com/QkYa8nMp (android dmesg) mainline dmesg doesn't have

The link has expired 🙁

> any relevant information other than spi/i2c probing, however, I've noticed
> both on deviceinfohw.ru and the dmesg that for some reason the touchscreen
> is on spi0.0 (even though DT says 8) and I'm not sure if that means it's on SPI
> but on a bugged out bus or if it's really just spi on bus 0

It means that it's on the SPI bus that probed first (index 0) 

[...]

> +&spi8 {
> +       spi-max-frequency = <5000000>;
> +
> +       touchscreen@0 {
> +               compatible = "st,fts2ba61y";
> +               reg = <0>;
> +
> +               vdd-supply = <&vreg_l8c_1p8>;
> +               avdd-supply = <&vreg_l11c_3p0>;
> +
> +               interrupt-parent = <&tlmm>;
> +               interrupts = <46 IRQ_TYPE_LEVEL_LOW>;
> +
> +               pinctrl-names = "default", "sleep";
> +               pinctrl-0 = <&tsp_int_active>;
> +               pinctrl-1 = <&tsp_int_sleep>;
> +
> +               status = "okay";
> +       };
> +
> +
> +       status = "okay";
> +};

this won't compile ^

Konrad