linux-kernel - Re: [PATCH 1/1] dt-bindings: net: dsa: nxp,sja1105: Add optional clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251014200701.owvbmsfcibwseqfr@skbuf>
Date: Tue, 14 Oct 2025 23:07:01 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Frank Li <Frank.Li@....com>
Cc: Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: net: dsa: nxp,sja1105: Add optional
 clock

On Fri, Oct 10, 2025 at 02:34:17PM -0400, Frank Li wrote:
> Add optional clock for OSC_IN and fix the below CHECK_DTBS warnings:
>   arch/arm/boot/dts/nxp/imx/imx6qp-prtwd3.dtb: switch@0 (nxp,sja1105q): Unevaluated properties are not allowed ('clocks' was unexpected)
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
> index e9dd914b0734c..607b7fe8d28ee 100644
> --- a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
> @@ -41,6 +41,9 @@ properties:
>        therefore discouraged.
>      maxItems: 1
>  
> +  clocks:
> +    maxItems: 1
> +
>    spi-cpha: true
>    spi-cpol: true
>  
> -- 
> 2.34.1
> 

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>

with the comment that you might want to add clk_prepare_enable() driver
support for it too. Someone who specifies a clock which isn't fixed
might be taken by surprise by the missing driver logic.