[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e9813a47-c40b-475a-8faf-de0811c9066e@oss.qualcomm.com>
Date: Tue, 14 Oct 2025 12:28:58 +0800
From: Jingyi Wang <jingyi.wang@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>,
Manivannan Sadhasivam <mani@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com,
trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com
Subject: Re: [PATCH 4/6] dt-bindings: remoteproc: qcom,pas: Document pas for
Kaanapali SoCCP
On 10/9/2025 6:27 PM, Krzysztof Kozlowski wrote:
> On 25/09/2025 08:37, Jingyi Wang wrote:
>> +
>> + glink-edge:
>> + $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
>> + unevaluatedProperties: false
>> + description: |
>
> Drop |
>
>
Will fix
>> + Qualcomm G-Link subnode which represents communication edge, channels
>> + and devices related to the Remoteproc.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - memory-region
>> + - clocks
>> + - clock-names
>> + - interrupts
>> + - interrupt-names
>> + - qcom,smem-states
>> + - qcom,smem-state-names
>> +
>> +unevaluatedProperties: false
>
> That's wrong in this context. But if you add missing (and corrected
> pas-common) then it would make sense.
>
Sorry I didn't get this point, could you make it more clear?
The property for Kaanapali SoCCP doesn't follow qcom,pas-common.yaml
(the interrupts are different) so it was not included here, like
"qcom,qcs404-cdsp-pil.yaml"
So I think just adding the missing "power-domains","power-domain-names"
under "required" will be okay?
Thanks,
Jingyi
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists