linux-kernel - Re: [PATCH] HID: Kconfig: Fix build error from CONFIG_HID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10b21bc4-01a5-43b7-b7e2-267f09ecab43@leemhuis.info>
Date: Tue, 14 Oct 2025 10:48:58 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Jonathan Denose <jdenose@...gle.com>, Kuan-Wei Chiu <visitorckw@...il.com>
Cc: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
 Randy Dunlap <rdunlap@...radead.org>,
 Lucas GISSOT <lucas.gissot.pro@...il.com>, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: Kconfig: Fix build error from CONFIG_HID_HAPTIC

On 10/13/25 23:23, Jonathan Denose wrote:
> On Mon, Oct 13, 2025 at 4:11 PM Kuan-Wei Chiu <visitorckw@...il.com> wrote:
>> On Mon, Oct 13, 2025 at 08:54:57PM +0000, Jonathan Denose wrote:
>>> Temporarily change CONFIG_HID_HAPTIC to be bool instead of tristate, until
>>> we implement a permanent solution.
>>>
>>> ---
>>
>> The "---" line here will cause many tools used for applying patches,
>> like git am, to discard the content below it [1].
>>
>> Please don't add this line unless you don't want the following content
>> to appear in the commit message.
>>
>> [1]: https://www.kernel.org/doc/html/v6.17/process/submitting-patches.html#commentary
>>
>> Regards,
>> Kuan-Wei
> 
> Yes, that was intentional, the information below the '---' was
> included as additional information and not for the commit message. 
But at least some of it should be in there (and likely all of it,
despite what checkpatch says) to make the commit-msg properly work
stand-alone. Especially Link: or Closes: tags to the reports (and I
don't care, but ideally with a preceding Reported-by: tag mentioning the
reporters) should be in there.
Documentation/process/submitting-patches.rst and
Documentation/process/5.Posting.rst explain this in more details.

Ciao, Thorsten