linux-kernel - Re: [PATCH] HID: Kconfig: Fix build error from CONFIG_HID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c94c8b1-b53d-4dc5-86b4-70c89b91fa15@infradead.org>
Date: Mon, 13 Oct 2025 18:24:53 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Kuan-Wei Chiu <visitorckw@...il.com>, Jonathan Denose <jdenose@...gle.com>
Cc: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
 Thorsten Leemhuis <linux@...mhuis.info>,
 Lucas GISSOT <lucas.gissot.pro@...il.com>, linux-input@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: Kconfig: Fix build error from CONFIG_HID_HAPTIC



On 10/13/25 2:29 PM, Kuan-Wei Chiu wrote:
> On Mon, Oct 13, 2025 at 04:23:36PM -0500, Jonathan Denose wrote:
>> On Mon, Oct 13, 2025 at 4:11 PM Kuan-Wei Chiu <visitorckw@...il.com> wrote:
>>>
>>> On Mon, Oct 13, 2025 at 08:54:57PM +0000, Jonathan Denose wrote:
>>>> Temporarily change CONFIG_HID_HAPTIC to be bool instead of tristate, until
>>>> we implement a permanent solution.
>>>>
>>>> ---
>>>
>>> The "---" line here will cause many tools used for applying patches,
>>> like git am, to discard the content below it [1].
>>>
>>> Please don't add this line unless you don't want the following content
>>> to appear in the commit message.
>>>
>>> [1]: https://www.kernel.org/doc/html/v6.17/process/submitting-patches.html#commentary
>>>
>>> Regards,
>>> Kuan-Wei
>>
>> Yes, that was intentional, the information below the '---' was
>> included as additional information and not for the commit message. The
>> error messages were too long, as was the link to the longer
>> discussion, and this caused errors in checkpatch.pl.
>>

checkpatch is just a dumb script. Don't let it determine what goes
into a patch description. It can (easily) be wrong.

> Then at least your Signed-off-by tag needs to be above the --- line?

Right.

-- 
~Randy