linux-kernel - Re: [PATCH] Hid: Intel-thc-hid: Intel-quickspi: switch first interrupt from level to edge detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13o2s0so-nq3r-5909-4n2n-o97q2s35025n@xreary.bet>
Date: Tue, 14 Oct 2025 11:29:01 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Even Xu <even.xu@...el.com>
cc: bentiss@...nel.org, srinivas.pandruvada@...ux.intel.com, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
    Rui Zhang <rui1.zhang@...el.com>
Subject: Re: [PATCH] Hid: Intel-thc-hid: Intel-quickspi: switch first interrupt
 from level to edge detection

On Fri, 19 Sep 2025, Even Xu wrote:

> The original implementation used level detection for the first interrupt
> after device reset to avoid potential interrupt line noise and missed
> interrupts during the initialization phase. However, this approach
> introduced unintended side effects when tested with certain touch panels,
> including:
>  - Delayed hardware interrupt response
>  - Multiple spurious interrupt triggers
> 
> Switching back to edge detection for the first interrupt resolves these
> issues while maintaining reliable interrupt handling.
> 
> Extensive testing across multiple platforms with touch panels from
> various vendors confirms this change introduces no regressions.
> 
> Fixes: 9d8d51735a3a ("HID: intel-thc-hid: intel-quickspi: Add HIDSPI protocol implementation")
> Tested-by: Rui Zhang <rui1.zhang@...el.com>
> Signed-off-by: Even Xu <even.xu@...el.com>

Applied to hid.git#for-6.18/upstream-fixes, thanks.

-- 
Jiri Kosina
SUSE Labs