linux-kernel - RE: [PATCH] Hid: Intel-thc-hid: Intel-quickspi: switch first interrupt from level to edge detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB60984422D391F9C82AE31243F4E8A@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Wed, 15 Oct 2025 00:26:37 +0000
From: "Xu, Even" <even.xu@...el.com>
To: Jiri Kosina <jikos@...nel.org>
CC: "bentiss@...nel.org" <bentiss@...nel.org>,
	"srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Zhang, Rui1"
	<rui1.zhang@...el.com>
Subject: RE: [PATCH] Hid: Intel-thc-hid: Intel-quickspi: switch first
 interrupt from level to edge detection

Thanks Jiri!

Best Regards,
Even Xu

> -----Original Message-----
> From: Jiri Kosina <jikos@...nel.org>
> Sent: Tuesday, October 14, 2025 5:29 PM
> To: Xu, Even <even.xu@...el.com>
> Cc: bentiss@...nel.org; srinivas.pandruvada@...ux.intel.com; linux-
> input@...r.kernel.org; linux-kernel@...r.kernel.org; Zhang, Rui1
> <rui1.zhang@...el.com>
> Subject: Re: [PATCH] Hid: Intel-thc-hid: Intel-quickspi: switch first interrupt from
> level to edge detection
> 
> On Fri, 19 Sep 2025, Even Xu wrote:
> 
> > The original implementation used level detection for the first
> > interrupt after device reset to avoid potential interrupt line noise
> > and missed interrupts during the initialization phase. However, this
> > approach introduced unintended side effects when tested with certain
> > touch panels,
> > including:
> >  - Delayed hardware interrupt response
> >  - Multiple spurious interrupt triggers
> >
> > Switching back to edge detection for the first interrupt resolves
> > these issues while maintaining reliable interrupt handling.
> >
> > Extensive testing across multiple platforms with touch panels from
> > various vendors confirms this change introduces no regressions.
> >
> > Fixes: 9d8d51735a3a ("HID: intel-thc-hid: intel-quickspi: Add HIDSPI
> > protocol implementation")
> > Tested-by: Rui Zhang <rui1.zhang@...el.com>
> > Signed-off-by: Even Xu <even.xu@...el.com>
> 
> Applied to hid.git#for-6.18/upstream-fixes, thanks.
> 
> --
> Jiri Kosina
> SUSE Labs