linux-kernel - Re: [PATCH v7 00/27] Legacy hardware/cache events as json

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9f3b996-4fb4-463a-8392-16115862903a@linaro.org>
Date: Wed, 15 Oct 2025 18:39:04 +0100
From: James Clark <james.clark@...aro.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 Xu Yang <xu.yang_2@....com>, Thomas Falcon <thomas.falcon@...el.com>,
 Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, Atish Patra <atishp@...osinc.com>,
 Beeman Strong <beeman@...osinc.com>, Leo Yan <leo.yan@....com>,
 Vince Weaver <vincent.weaver@...ne.edu>, Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH v7 00/27] Legacy hardware/cache events as json



On 15/10/2025 4:53 pm, Namhyung Kim wrote:
> On Sun, 05 Oct 2025 11:24:03 -0700, Ian Rogers wrote:
> 
>> Mirroring similar work for software events in commit 6e9fa4131abb
>> ("perf parse-events: Remove non-json software events"). These changes
>> migrate the legacy hardware and cache events to json.  With no hard
>> coded legacy hardware or cache events the wild card, case
>> insensitivity, etc. is consistent for events. This does, however, mean
>> events like cycles will wild card against all PMUs. A change doing the
>> same was originally posted and merged from:
>> https://lore.kernel.org/r/20240416061533.921723-10-irogers@google.com
>> and reverted by Linus in commit 4f1b067359ac ("Revert "perf
>> parse-events: Prefer sysfs/JSON hardware events over legacy"") due to
>> his dislike for the cycles behavior on ARM with perf record. Earlier
>> patches in this series make perf record event opening failures
>> non-fatal and hide the cycles event's failure to open on ARM in perf
>> record, so it is expected the behavior will now be transparent in perf
>> record on ARM. perf stat with a cycles event will wildcard open the
>> event on all PMUs, however, with default events the cycles event will
>> only be opened on core PMUs.
>>
>> [...]
> 
> Applied to perf-tools-next, thanks!
> 
> Best regards,
> Namhyung
> 

Hi Namhyung,

I'm still getting the build failure that I mentioned on patch 5. This 
only seems to happen with out of source builds:

   $ make -C tools/perf O=../build/local/ V=1


   static const struct pmu_sys_events pmu_sys_event_tables[] = {
         {
-               .event_table = {
-                       .pmus = pmu_events__test_soc_sys,
-                       .num_pmus = ARRAY_SIZE(pmu_events__test_soc_sys)
-               },
-               .name = "pmu_events__test_soc_sys",
-       },
-       {
                 .event_table = { 0, 0 },
                 .metric_table = { 0, 0 },
         },
make[3]: *** [pmu-events/Build:54: 
/home/james/workspace/linux/build/local/pmu-events/empty-pmu-events.log] 
Error 1

Thanks
James