lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251015191453.76b9a5e6@gandalf.local.home>
Date: Wed, 15 Oct 2025 19:14:53 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Steven Rostedt <rostedt@...nel.org>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org, Masami
 Hiramatsu <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Arnd Bergmann <arnd@...db.de>, Masahiro Yamada
 <masahiroy@...nel.org>, Nicolas Schier <nicolas.schier@...ux.dev>, Nick
 Desaulniers <nick.desaulniers+lkml@...il.com>, Catalin Marinas
 <catalin.marinas@....com>, Linus Torvalds <torvalds@...ux-foundation.org>,
 Randy Dunlap <rdunlap@...radead.org>, Stephen Rothwell
 <sfr@...b.auug.org.au>
Subject: Re: [PATCH v9 2/4] tracing: Add a tracepoint verification check at
 build time

On Wed, 15 Oct 2025 16:12:19 -0700
Nathan Chancellor <nathan@...nel.org> wrote:

> Hi Steve,
> 
> The kbuild portions of this seem fine, as they mirror existing patterns.
> 
> On Wed, Oct 15, 2025 at 04:38:44PM -0400, Steven Rostedt wrote:
> > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> > index 8a9a2e732a65..08ca759fb992 100644
> > --- a/include/asm-generic/vmlinux.lds.h
> > +++ b/include/asm-generic/vmlinux.lds.h
> > @@ -1048,6 +1048,7 @@ defined(CONFIG_AUTOFDO_CLANG) || defined(CONFIG_PROPELLER_CLANG)
> >  	*(.no_trim_symbol)						\
> >  	/* ld.bfd warns about .gnu.version* even when not emitted */	\
> >  	*(.gnu.version*)						\
> > +	*(__tracepoint_check)  
> 
> Please add a trailing slash like the other lines so that one does not
> need to be added when someone else needs to grow this macro (also helps
> with 'git blame').

Sure thing! Thanks for looking at these patches!

-- Steve


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ