linux-kernel - Re: [PATCH v3 1/5] mm: fix off-by-one error in VMA count limit checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e539c9b3-72cd-44dc-b4de-15376b41b56a@lucifer.local>
Date: Wed, 15 Oct 2025 10:10:26 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Hugh Dickins <hughd@...gle.com>, Kalesh Singh <kaleshsingh@...gle.com>,
        akpm@...ux-foundation.org, minchan@...nel.org, david@...hat.com,
        rppt@...nel.org, pfalcato@...e.de, kernel-team@...roid.com,
        android-mm@...gle.com, stable@...r.kernel.org,
        SeongJae Park <sj@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
        Kees Cook <kees@...nel.org>, Vlastimil Babka <vbabka@...e.cz>,
        Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
        Jann Horn <jannh@...gle.com>, Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Valentin Schneider <vschneid@...hat.com>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-trace-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v3 1/5] mm: fix off-by-one error in VMA count limit checks

On Tue, Oct 14, 2025 at 01:51:31PM -0400, Liam R. Howlett wrote:
> In either case, it seems like a good idea to adjust the comments to
> state that the count may not change.

Yes, I am busy trying to catch up with my backlog (do intend to look at
this more closely) but wanted to say - let's please document what we're
doing here in a comment.

It's my firm conviction that we in mm need to eliminate as many instances
of 'just have to know' or implicit knowledge that is either undocumented or
tricky to find (buried in a commit message from X yrs ago for instance).

Cheers, Lorenzo