linux-kernel - Re: [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251015090957.1533003-1-yangzh0906@thundersoft.com>
Date: Wed, 15 Oct 2025 17:09:57 +0800
From: Albert Yang <yangzh0906@...ndersoft.com>
To: robh@...nel.org
Cc: adrian.hunter@...el.com,
	arnd@...db.de,
	bst-upstream@...ai.top,
	catalin.marinas@....com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	gordon.ge@....ai,
	krzk+dt@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org,
	ulf.hansson@...aro.org,
	will@...nel.org,
	yangzh0906@...ndersoft.com
Subject: Re: [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller

Hi Rob,

Thank you for your review and feedback on v4!

On Tue, Sep 23, 2025 at 08:56:20AM -0500, Rob Herring wrote:
> On Tue, Sep 23, 2025 at 02:10:10PM +0800, Albert Yang wrote:
> > Changes for v4:
>
> Thanks for the changelog here, but the subject should have 'PATCH v4' so 
> various tools work.

Acknowledged. I'll ensure the subject line follows the correct format 
"[PATCH v5 X/Y]" in the next version.

> Filename should match compatible.

Agreed. I will rename the file from:
  bst,dwcmshc-sdhci.yaml
to:
  bst,c1200-sdhci.yaml

and update the $id field accordingly from:
  http://devicetree.org/schemas/mmc/bst,dwcmshc-sdhci.yaml#
to:
  http://devicetree.org/schemas/mmc/bst,c1200-sdhci.yaml#

> > +  clock-names:
> > +    items:
> > +      - const: core
>
> Not really any point in having -names when there is only 1 entry.> Not really any point in having -names when there is only 1 entry.

You're right. I'll remove the clock-names property and its entry from the 
required properties list.

> > +  memory-region:
> > +    maxItems: 1
>
> Having this is odd. Please add a description saying what it is for.
>> Having this is odd. Please add a description saying what it is for.

I'll add a description for memory-region:

  memory-region:
    maxItems: 1
    description:
      Phandle to a reserved memory region for DMA bounce buffer. The BST C1200
      SDHCI controller supports only 32-bit DMA addressing, while system memory
      may be located above 4GB address space.

Additionally, I've already corrected the example's compatible string from 
"bst,c1200-dwcmshc-sdhci" to "bst,c1200-sdhci" to match the property definition.

I'll prepare v5 with all the above changes addressed.

Best regards,
Albert Yang