linux-kernel - Re: [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251015093102.1554881-1-yangzh0906@thundersoft.com>
Date: Wed, 15 Oct 2025 17:31:02 +0800
From: Albert Yang <yangzh0906@...ndersoft.com>
To: robh@...nel.org
Cc: adrian.hunter@...el.com,
	arnd@...db.de,
	bst-upstream@...ai.top,
	catalin.marinas@....com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	gordon.ge@....ai,
	krzk+dt@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org,
	ulf.hansson@...aro.org,
	will@...nel.org,
	yangzh0906@...ndersoft.com
Subject: Re: [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller

Hi Rob,

Thank you for running the dt_binding_check on this patch!

On Tue, Sep 23, 2025 at 05:13:09AM -0500, Rob Herring (Arm) wrote:
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.example.dtb: /example-0/bus/mmc@...00000: failed to match any schema with compatible: ['bst,c1200-dwcmshc-sdhci']

This error occurred because in v4, while I updated the dts compatible property 
definition to "bst,c1200-sdhci" (as requested in review), I failed to update 
the compatible string in the example node accordingly. The example was still 
using the old "bst,c1200-dwcmshc-sdhci", causing the schema validation to fail.

I have now corrected the example's compatible string from:
    compatible = "bst,c1200-dwcmshc-sdhci";
to:
    compatible = "bst,c1200-sdhci";

Following your suggestion, I've upgraded dtschema:
    pip3 install dtschema --upgrade

and verified the fix with:
    make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/bst,c1200-sdhci.yaml

The binding now passes all validation checks. This fix will be included in v5.

Best regards,
Albert Yang