linux-kernel - Re: [PATCH V2] mm/khugepaged: fix comment for default scan sleep duration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52c8ac78-7a79-4a92-a371-6fb4520a84d9@redhat.com>
Date: Wed, 15 Oct 2025 11:38:17 +0200
From: David Hildenbrand <david@...hat.com>
To: wang lian <lianux.mm@...il.com>, Andrew Morton <akpm@...ux-foundation.org>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Zi Yan <ziy@...dia.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Nico Pache <npache@...hat.com>,
 Ryan Roberts <ryan.roberts@....com>, Dev Jain <dev.jain@....com>,
 Barry Song <baohua@...nel.org>, Lance Yang <lance.yang@...ux.dev>,
 Andrea Arcangeli <aarcange@...hat.com>, Rik van Riel <riel@...hat.com>,
 Wei Yang <richard.weiyang@...il.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] mm/khugepaged: fix comment for default scan sleep
 duration

On 15.10.25 11:29, wang lian wrote:
> The comment for khugepaged_scan_sleep_millisecs incorrectly states
> the default scan period is 30 seconds. The actual default value in the
> code is 10000ms (10 seconds).
> 
> This patch corrects the comment to match the code, preventing potential
> confusion. The incorrect comment has existed since the feature was
> first introduced.

"While at it, replace the magic value 512 by HPAGE_PMD_NR and use 'ptes'."

> 
> Fixes: ba76149f47d8 ("thp: khugepaged")

I prefer to not have fixes for comments. It tricks people into thinking 
that this might warrant a backport.

Likely no need to resend and Andrew can fix it up when applying.

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers

David / dhildenb