linux-kernel - Re: [PATCH 04/24] arm64: dts: qcom: glymur: Add QUPv3 configuration for serial engines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9865ae77-0051-4a4b-95a6-6e655fc274f3@oss.qualcomm.com>
Date: Wed, 15 Oct 2025 16:03:58 +0530
From: Jyothi Kumar Seerapu <jyothi.seerapu@....qualcomm.com>
To: Abel Vesa <abel.vesa@...aro.org>,
        Pankaj Patil <pankaj.patil@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/24] arm64: dts: qcom: glymur: Add QUPv3 configuration
 for serial engines



On 10/11/2025 4:41 PM, Abel Vesa wrote:
> On 25-10-11 14:06:44, Abel Vesa wrote:
>> On 25-09-25 12:02:12, Pankaj Patil wrote:
>>> From: Jyothi Kumar Seerapu <jyothi.seerapu@....qualcomm.com>
>>>
>>> Add device tree support for QUPv3 serial engine protocols on Glymur.
>>> Glymur has 24 QUP serial engines across 3 QUP wrappers, each with
>>> support of GPI DMA engines.
>>>
>>> Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@....qualcomm.com>
>>> Signed-off-by: Pankaj Patil <pankaj.patil@....qualcomm.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/glymur-crd.dts |   43 +
>>>   arch/arm64/boot/dts/qcom/glymur.dtsi    | 3041 +++++++++++++++++++++++++++++--
>>>   2 files changed, 2936 insertions(+), 148 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
>>> index f1c5a0cb483670e9f8044e250950693b4a015479..8674465b22707207523caa8ad635d95a3396497a 100644
>>> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
>>> @@ -707,6 +707,32 @@ gcc: clock-controller@...000 {
>>>   			#power-domain-cells = <1>;
>>>   		};
>>>   
>>> +		gpi_dma2: dma-controller@...000 {
>>> +			compatible = "qcom,glymur-gpi-dma", "qcom,sm6350-gpi-dma";
>>> +			reg = <0 0x00800000 0 0x60000>;
>>> +			interrupts = <GIC_SPI 588 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 589 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 590 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 591 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 592 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 593 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 594 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 595 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 596 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 597 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 598 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 599 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_ESPI 129 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_ESPI 130 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_ESPI 131 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_ESPI 132 IRQ_TYPE_LEVEL_HIGH>;
>>> +			dma-channels = <16>;
>>> +			dma-channel-mask = <0x3f>;
>>> +			#dma-cells = <3>;
>>> +			iommus = <&apps_smmu 0xd76 0x0>;
>>> +			status = "ok";
>>
>> s/ok/okay/
>>
>> Everywhere actually.
>>
> 
> Actually no. Maybe drop entirely like Konrad already suggested.
> 
> But then everywhere else you do "ok" please replace with "okay",
> otherwise dtbs_check complains.

Sure, will review it.>