linux-kernel - Re: [PATCH 1/4] dt-bindings: iio: adc: Add the Renesas RZ/N1 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57def480-6f42-4f84-a9ff-3452520b3c3f@kernel.org>
Date: Thu, 16 Oct 2025 17:49:33 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Herve Codina (Schneider Electric)" <herve.codina@...tlin.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>,
 Magnus Damm <magnus.damm@...il.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Pascal Eberhard <pascal.eberhard@...com>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 1/4] dt-bindings: iio: adc: Add the Renesas RZ/N1 ADC

On 15/10/2025 16:28, Herve Codina (Schneider Electric) wrote:
> +  clocks:
> +    items:
> +      - description: APB internal bus clock
> +      - description: ADC clock
> +
> +  clock-names:
> +    items:
> +      - const: pclk
> +      - const: adc-clk

Just 'adc'

clk is redundant

> +
> +  power-domains:
> +    maxItems: 1
> +
> +  adc1-avdd-supply:
> +    description:
> +      ADC1 analog power supply.
> +
> +  adc1-vref-supply:
> +    description:
> +      ADC1 reference voltage supply.
> +
> +  adc2-avdd-supply:
> +    description:
> +      ADC2 analog power supply.
> +
> +  adc2-vref-supply:
> +    description:
> +      ADC2 reference voltage supply.
> +
> +  '#io-channel-cells':
> +    const: 1
> +    description: |
> +      Channels numbers available:
> +        if ADC1 is used (i.e. adc1-{avdd,vref}-supply present):
> +          - 0: ADC1 IN0
> +          - 1: ADC1 IN1
> +          - 2: ADC1 IN2
> +          - 3: ADC1 IN3
> +          - 4: ADC1 IN4
> +          - 5: ADC1 IN6
> +          - 6: ADC1 IN7
> +          - 7: ADC1 IN8
> +        if ADC2 is used (i.e. adc2-{avdd,vref}-supply present):
> +          - 8: ADC2 IN0
> +          - 9: ADC2 IN1
> +          - 10: ADC2 IN2
> +          - 11: ADC2 IN3
> +          - 12: ADC2 IN4
> +          - 13: ADC2 IN6
> +          - 14: ADC2 IN7
> +          - 15: ADC2 IN8
> +
> +additionalProperties: false

This goes just before example
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - power-domains
> +  - '#io-channel-cells'
> +
> +dependencies:
> +  # None or both adc1-avdd-supply / adc1-vref-supply should be present
> +  adc1-avdd-supply: [ adc1-vref-supply ]
> +  adc1-vref-supply: [ adc1-avdd-supply ]
> +  # None or both adc2-avdd-supply / adc2-vref-supply should be present
> +  adc2-avdd-supply: [ adc2-vref-supply ]
> +  adc2-vref-supply: [ adc2-avdd-supply ]

Above seems unnecessary. The anyOf below should already enforce that, no?

> +
> +# At least one of avvd/vref supplies
> +anyOf:
> +  - required:
> +      - adc1-vref-supply
> +      - adc1-avdd-supply
> +  - required:
> +      - adc2-vref-supply
> +      - adc2-avdd-supply
> +



Best regards,
Krzysztof