linux-kernel - Re: [PATCH v1 2/2] pmdomain: rockchip: Add support for RV1126B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2176528.bB369e8A3T@diego>
Date: Thu, 16 Oct 2025 18:13:34 +0200
From: Heiko Stübner <heiko@...ech.de>
To: Finley Xiao <finley.xiao@...k-chips.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 ulf.hansson@...aro.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 finley.xiao@...k-chips.com, zhangqing@...k-chips.com,
 sugar.zhang@...k-chips.com, huangtao@...k-chips.com
Subject: Re: [PATCH v1 2/2] pmdomain: rockchip: Add support for RV1126B

Am Donnerstag, 16. Oktober 2025, 15:41:03 Mitteleuropäische Sommerzeit schrieb Finley Xiao:
> Add configuration and power domains for RV1126 SoC.
> 
> Signed-off-by: Finley Xiao <finley.xiao@...k-chips.com>
> ---

[...]

> @@ -1104,6 +1122,13 @@ static const struct rockchip_domain_info rv1126_pm_domains[] = {
>  	[RV1126_PD_USB]		= DOMAIN_RV1126("usb", BIT(9), BIT(15), BIT(15),  false),
>  };
>  
> +static const struct rockchip_domain_info rv1126b_pm_domains[] = {
> +					      /* name    pwr     req      wakeup */
> +	[RV1126B_PD_NPU]	= DOMAIN_RV1126B("npu",  BIT(0), BIT(8),  false),
> +	[RV1126B_PD_VDO]	= DOMAIN_RV1126B("vdo",  BIT(1), BIT(9),  false),
> +	[RV1126B_PD_AISP]	= DOMAIN_RV1126B("aisp", BIT(2), BIT(10), false),
> +};
> +

same clarification needed as for patch 1 ... is it aiisp (with 2 "i")?
As described everywhere in the TRM.

Other than that I checked the bits and registers against the TRM, so

Reviewed-by: Heiko Stuebner <heiko@...ech.de>


Heiko