linux-kernel - Re: [PATCH v1 1/2] dt-bindings: power: rockchip: Add support for RV1126B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5a07602-360c-420c-aaa0-664d5d1ed760@kernel.org>
Date: Thu, 16 Oct 2025 19:27:59 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Finley Xiao <finley.xiao@...k-chips.com>, heiko@...ech.de
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 ulf.hansson@...aro.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 zhangqing@...k-chips.com, sugar.zhang@...k-chips.com, huangtao@...k-chips.com
Subject: Re: [PATCH v1 1/2] dt-bindings: power: rockchip: Add support for
 RV1126B

On 16/10/2025 15:41, Finley Xiao wrote:
> Add the compatible string and power domain IDs for RV1126B SoC.

And it is not compatible with RV1126 because?

> 
> signed-off-by: Finley Xiao <finley.xiao@...k-chips.com>
> ---
>  .../power/rockchip,power-controller.yaml        |  2 ++
>  .../dt-bindings/power/rockchip,rv1126b-power.h  | 17 +++++++++++++++++
>  2 files changed, 19 insertions(+)
>  create mode 100644 include/dt-bindings/power/rockchip,rv1126b-power.h
> 
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index a884e49c995f..f9db602de258 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -46,6 +46,7 @@ properties:
>        - rockchip,rk3576-power-controller
>        - rockchip,rk3588-power-controller
>        - rockchip,rv1126-power-controller
> +      - rockchip,rv1126b-power-controller
>  
>    "#power-domain-cells":
>      const: 1
> @@ -126,6 +127,7 @@ $defs:
>            "include/dt-bindings/power/rk3568-power.h"
>            "include/dt-bindings/power/rk3588-power.h"
>            "include/dt-bindings/power/rockchip,rv1126-power.h"
> +          "include/dt-bindings/power/rockchip,rv1126b-power.h"
>  
>        clocks:
>          minItems: 1
> diff --git a/include/dt-bindings/power/rockchip,rv1126b-power.h b/include/dt-bindings/power/rockchip,rv1126b-power.h
> new file mode 100644
> index 000000000000..0a418f16e4ea
> --- /dev/null
> +++ b/include/dt-bindings/power/rockchip,rv1126b-power.h

Use rather filename matching compatible fully.

> @@ -0,0 +1,17 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */


Odd license. Please use recommended licenses.


Best regards,
Krzysztof