linux-kernel - Re: [PATCH] dt-bindings: Fix inconsistent quoting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <176057439666.933167.2958808777480882513.robh@kernel.org>
Date: Wed, 15 Oct 2025 19:26:36 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Vladimir Oltean <olteanv@...il.com>, 
 Nicolas Ferre <nicolas.ferre@...rochip.com>, devicetree@...r.kernel.org, 
 Jakub Kicinski <kuba@...nel.org>, Andy Shevchenko <andy@...nel.org>, 
 Joel Stanley <joel@....id.au>, Bjorn Helgaas <bhelgaas@...gle.com>, 
 Andrew Jeffery <andrew@...econstruct.com.au>, Lee Jones <lee@...nel.org>, 
 Daire McNamara <daire.mcnamara@...rochip.com>, 
 Mauro Carvalho Chehab <mchehab@...nel.org>, 
 Eric Dumazet <edumazet@...gle.com>, linux-iio@...r.kernel.org, 
 Manivannan Sadhasivam <mani@...nel.org>, Andrew Lunn <andrew@...n.ch>, 
 Michael Hennerich <Michael.Hennerich@...log.com>, 
 Lorenzo Pieralisi <lpieralisi@...nel.org>, Vinod Koul <vkoul@...nel.org>, 
 Jonathan Cameron <jic23@...nel.org>, linux-phy@...ts.infradead.org, 
 Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org, 
 Paolo Abeni <pabeni@...hat.com>, Kishon Vijay Abraham I <kishon@...nel.org>, 
 Stephen Boyd <sboyd@...nel.org>, Jassi Brar <jassisinghbrar@...il.com>, 
 linux-gpio@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>, 
 linux-media@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
 Lars-Peter Clausen <lars@...afoo.de>, 
 Alexandre Belloni <alexandre.belloni@...tlin.com>, 
 linux-clk@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
 linux-pci@...r.kernel.org, Shawn Guo <shawnguo@...nel.org>, 
 Claudiu Beznea <claudiu.beznea@...on.dev>, linux-kernel@...r.kernel.org, 
 Geert Uytterhoeven <geert+renesas@...der.be>, 
 Thierry Reding <thierry.reding@...il.com>, 
 Fabio Estevam <festevam@...il.com>, linux-arm-kernel@...ts.infradead.org, 
 Linus Walleij <linus.walleij@...aro.org>, 
 Krzysztof Wilczyński <kwilczynski@...nel.org>, 
 Bjorn Andersson <andersson@...nel.org>, 
 Nuno Sá <nuno.sa@...log.com>, 
 Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] dt-bindings: Fix inconsistent quoting


On Wed, 15 Oct 2025 18:16:24 -0500, Rob Herring (Arm) wrote:
> yamllint has gained a new check which checks for inconsistent quoting
> (mixed " and ' quotes within a file). Fix all the cases yamllint found
> so we can enable the check (once the check is in a release). Use
> whichever quoting is dominate in the file.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  .../arm/altera/socfpga-clk-manager.yaml       |  4 ++--
>  .../bindings/clock/nvidia,tegra124-car.yaml   |  8 ++++----
>  .../bindings/clock/nvidia,tegra20-car.yaml    |  6 +++---
>  .../devicetree/bindings/gpio/gpio-mxs.yaml    |  9 +++++----
>  .../bindings/gpio/snps,dw-apb-gpio.yaml       |  4 ++--
>  .../bindings/iio/temperature/adi,ltc2983.yaml | 20 +++++++++----------
>  .../mailbox/qcom,apcs-kpss-global.yaml        | 16 +++++++--------
>  .../mailbox/xlnx,zynqmp-ipi-mailbox.yaml      |  2 +-
>  .../bindings/media/fsl,imx6q-vdoa.yaml        |  2 +-
>  .../devicetree/bindings/mfd/aspeed-lpc.yaml   |  4 ++--
>  .../devicetree/bindings/mfd/ti,twl.yaml       |  4 ++--
>  .../bindings/net/ethernet-switch.yaml         |  2 +-
>  .../pci/plda,xpressrich3-axi-common.yaml      |  2 +-
>  .../bindings/phy/motorola,cpcap-usb-phy.yaml  |  4 ++--
>  .../pinctrl/microchip,sparx5-sgpio.yaml       | 12 +++++------
>  .../bindings/pinctrl/qcom,pmic-gpio.yaml      | 10 +++++-----
>  .../bindings/pinctrl/qcom,pmic-mpp.yaml       |  6 +++---
>  .../bindings/pinctrl/renesas,pfc.yaml         |  4 ++--
>  .../bindings/pinctrl/renesas,rza1-ports.yaml  |  2 +-
>  .../pinctrl/renesas,rzg2l-pinctrl.yaml        |  2 +-
>  .../pinctrl/renesas,rzv2m-pinctrl.yaml        |  2 +-
>  .../bindings/power/renesas,sysc-rmobile.yaml  |  4 ++--
>  .../soc/microchip/atmel,at91rm9200-tcb.yaml   |  8 ++++----
>  .../soc/tegra/nvidia,tegra20-pmc.yaml         | 12 +++++------
>  24 files changed, 75 insertions(+), 74 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/pinctrl/renesas,pfc.example.dts:90.36-37 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:132: Documentation/devicetree/bindings/pinctrl/renesas,pfc.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1525: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251015232015.846282-1-robh@kernel.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.