linux-kernel - Re: [PATCH 1/4] i2c: machxo2: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f91f3c15-0070-413a-8f35-541149a07f0b@kernel.org>
Date: Thu, 16 Oct 2025 07:44:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Matthias Schiffer <matthias.schiffer@...tq-group.com>,
 Andi Shyti <andi.shyti@...nel.org>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux@...tq-group.com
Subject: Re: [PATCH 1/4] i2c: machxo2: new driver

On 15/10/2025 13:03, Matthias Schiffer wrote:
> +
> +module_platform_driver(machxo2_i2c_driver);
> +
> +MODULE_AUTHOR("TQ-Systems GmbH <linux@...tq-group.com>");
> +MODULE_DESCRIPTION("Lattice MachXO2 I2C bus driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:i2c-machxo2");

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.


Best regards,
Krzysztof