linux-kernel - RE: [PATCH v16 2/5] x86/cpufeatures: Add X86_FEATURE_SGX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB94954D6EE807C00D5A29E520E7E9A@IA1PR11MB9495.namprd11.prod.outlook.com>
Date: Thu, 16 Oct 2025 06:38:22 +0000
From: "Reshetova, Elena" <elena.reshetova@...el.com>
To: "Hansen, Dave" <dave.hansen@...el.com>
CC: "jarkko@...nel.org" <jarkko@...nel.org>, "seanjc@...gle.com"
	<seanjc@...gle.com>, "Huang, Kai" <kai.huang@...el.com>, "mingo@...nel.org"
	<mingo@...nel.org>, "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>, "Mallick, Asit K"
	<asit.k.mallick@...el.com>, "Scarlata, Vincent R"
	<vincent.r.scarlata@...el.com>, "Cai, Chong" <chongc@...gle.com>, "Aktas,
 Erdem" <erdemaktas@...gle.com>, "Annapurve, Vishal" <vannapurve@...gle.com>,
	"Bondarevska, Nataliia" <bondarn@...gle.com>, "Raynor, Scott"
	<scott.raynor@...el.com>, Dave Hansen <dave.hansen@...ux.intel.com>
Subject: RE: [PATCH v16 2/5] x86/cpufeatures: Add X86_FEATURE_SGX_EUPDATESVN
 feature flag



> -----Original Message-----
> From: Hansen, Dave <dave.hansen@...el.com>
> Sent: Wednesday, October 15, 2025 11:43 PM
> To: Reshetova, Elena <elena.reshetova@...el.com>
> Cc: jarkko@...nel.org; seanjc@...gle.com; Huang, Kai
> <kai.huang@...el.com>; mingo@...nel.org; linux-sgx@...r.kernel.org; linux-
> kernel@...r.kernel.org; x86@...nel.org; Mallick, Asit K
> <asit.k.mallick@...el.com>; Scarlata, Vincent R <vincent.r.scarlata@...el.com>;
> Cai, Chong <chongc@...gle.com>; Aktas, Erdem <erdemaktas@...gle.com>;
> Annapurve, Vishal <vannapurve@...gle.com>; Bondarevska, Nataliia
> <bondarn@...gle.com>; Raynor, Scott <scott.raynor@...el.com>; Dave Hansen
> <dave.hansen@...ux.intel.com>
> Subject: Re: [PATCH v16 2/5] x86/cpufeatures: Add
> X86_FEATURE_SGX_EUPDATESVN feature flag
> 
> On 10/10/25 01:52, Elena Reshetova wrote:
> > diff --git a/tools/arch/x86/include/asm/cpufeatures.h
> b/tools/arch/x86/include/asm/cpufeatures.h
> > index 06fc0479a23f..30761c905b7d 100644
> > --- a/tools/arch/x86/include/asm/cpufeatures.h
> > +++ b/tools/arch/x86/include/asm/cpufeatures.h
> > @@ -495,6 +495,7 @@
> >  #define X86_FEATURE_TSA_SQ_NO		(21*32+11) /* AMD CPU not
> vulnerable to TSA-SQ */
> >  #define X86_FEATURE_TSA_L1_NO		(21*32+12) /* AMD CPU not
> vulnerable to TSA-L1 */
> >  #define X86_FEATURE_CLEAR_CPU_BUF_VM	(21*32+13) /* Clear CPU
> buffers using VERW before VMRUN */
> > +#define X86_FEATURE_SGX_EUPDATESVN	(21*32+16) /* Support for
> ENCLS[EUPDATESVN] instruction */
> 
> Sorry I didn't catch this before, but we don't patch this tools/ file
> for individual features. We just sync the main copy over to here from
> time to time. This hunk needs to die.
> 
> Second, please don't send things during the merge window. That's both
> because we're busy, but also because I'm going to merge your code on top
> of $VERSION-rc1. I'm not sure what you rebased to, but things don't
> apply cleanly now.
> 
> Can you please fix the tools/ thing, rebase this on -rc1, retest and resend?

Sure, will do, thanks!
Previous version was based on x86_tip/master, will rebase on 6.18-rc1.