Message-Id: <6241800d-9456-4d5f-b55d-611e33f2c446@app.fastmail.com>
Date: Thu, 16 Oct 2025 09:59:11 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Byungchul Park" <byungchul@...com>
Cc: "Mathieu Desnoyers" <mathieu.desnoyers@...icios.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, kernel_team@...ynix.com,
 "Linus Torvalds" <torvalds@...ux-foundation.org>,
 "Damien Le Moal" <damien.lemoal@...nsource.wdc.com>,
 linux-ide@...r.kernel.org, "Andreas Dilger" <adilger.kernel@...ger.ca>,
 linux-ext4@...r.kernel.org, "Ingo Molnar" <mingo@...hat.com>,
 "Peter Zijlstra" <peterz@...radead.org>, "Will Deacon" <will@...nel.org>,
 "Thomas Gleixner" <tglx@...utronix.de>,
 "Steven Rostedt" <rostedt@...dmis.org>,
 "Joel Fernandes" <joel@...lfernandes.org>,
 "Sasha Levin" <sashal@...nel.org>,
 "Daniel Vetter" <daniel.vetter@...ll.ch>, duyuyang@...il.com,
 "Johannes Berg" <johannes.berg@...el.com>, "Tejun Heo" <tj@...nel.org>,
 "Theodore Ts'o" <tytso@....edu>, "Matthew Wilcox" <willy@...radead.org>,
 "Dave Chinner" <david@...morbit.com>,
 "Amir Goldstein" <amir73il@...il.com>, kernel-team@....com,
 linux-mm@...ck.org, "Andrew Morton" <akpm@...ux-foundation.org>,
 "Michal Hocko" <mhocko@...nel.org>, "Minchan Kim" <minchan@...nel.org>,
 "Johannes Weiner" <hannes@...xchg.org>, vdavydov.dev@...il.com,
 "SeongJae Park" <sj@...nel.org>, jglisse@...hat.com,
 "Dennis Zhou" <dennis@...nel.org>, "Christoph Lameter" <cl@...ux.com>,
 "Pekka Enberg" <penberg@...nel.org>,
 "David Rientjes" <rientjes@...gle.com>,
 "Vlastimil Babka" <vbabka@...e.cz>, ngupta@...are.org,
 linux-block@...r.kernel.org, "Josef Bacik" <josef@...icpanda.com>,
 linux-fsdevel@...r.kernel.org, "Jan Kara" <jack@...e.cz>,
 "Jeff Layton" <jlayton@...nel.org>,
 "Dan Williams" <dan.j.williams@...el.com>,
 "Christoph Hellwig" <hch@...radead.org>,
 "Darrick J. Wong" <djwong@...nel.org>, dri-devel@...ts.freedesktop.org,
 rodrigosiqueiramelo@...il.com, melissa.srw@...il.com,
 hamohammed.sa@...il.com, harry.yoo@...cle.com, chris.p.wilson@...el.com,
 "Gwan-gyeong Mun" <gwan-gyeong.mun@...el.com>,
 max.byungchul.park@...il.com, "Boqun Feng" <boqun.feng@...il.com>,
 "Waiman Long" <longman@...hat.com>, yunseong.kim@...csson.com,
 ysk@...lloc.com, "Yeoreum Yun" <yeoreum.yun@....com>,
 Netdev <netdev@...r.kernel.org>,
 "Matthew Brost" <matthew.brost@...el.com>, her0gyugyu@...il.com,
 "Jonathan Corbet" <corbet@....net>,
 "Catalin Marinas" <catalin.marinas@....com>,
 "Borislav Petkov" <bp@...en8.de>,
 "Dave Hansen" <dave.hansen@...ux.intel.com>, x86@...nel.org,
 "H. Peter Anvin" <hpa@...or.com>, "Andy Lutomirski" <luto@...nel.org>,
 "Sumit Semwal" <sumit.semwal@...aro.org>, gustavo@...ovan.org,
 Christian König <christian.koenig@....com>,
 "Andi Shyti" <andi.shyti@...nel.org>,
 "Lorenzo Stoakes" <lorenzo.stoakes@...cle.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>,
 "Mike Rapoport" <rppt@...nel.org>,
 "Suren Baghdasaryan" <surenb@...gle.com>,
 "Luis Chamberlain" <mcgrof@...nel.org>,
 "Petr Pavlu" <petr.pavlu@...e.com>, da.gomez@...nel.org,
 "Sami Tolvanen" <samitolvanen@...gle.com>,
 "Paul E. McKenney" <paulmck@...nel.org>,
 "Frederic Weisbecker" <frederic@...nel.org>, neeraj.upadhyay@...nel.org,
 joelagnelf@...dia.com, "Josh Triplett" <josh@...htriplett.org>,
 "Uladzislau Rezki (Sony)" <urezki@...il.com>,
 "Lai Jiangshan" <jiangshanlai@...il.com>, qiang.zhang@...ux.dev,
 "Juri Lelli" <juri.lelli@...hat.com>,
 "Vincent Guittot" <vincent.guittot@...aro.org>,
 "Dietmar Eggemann" <dietmar.eggemann@....com>,
 "Benjamin Segall" <bsegall@...gle.com>, "Mel Gorman" <mgorman@...e.de>,
 "Valentin Schneider" <vschneid@...hat.com>,
 "Chuck Lever" <chuck.lever@...cle.com>, neil@...wn.name,
 okorniev@...hat.com, "Dai Ngo" <Dai.Ngo@...cle.com>,
 "Tom Talpey" <tom@...pey.com>, trondmy@...nel.org,
 "Anna Schumaker" <anna@...nel.org>, "Kees Cook" <kees@...nel.org>,
 "Sebastian Andrzej Siewior" <bigeasy@...utronix.de>,
 "Clark Williams" <clrkwllms@...nel.org>,
 "Mark Rutland" <mark.rutland@....com>, ada.coupriediaz@....com,
 kristina.martsenko@....com, "Kefeng Wang" <wangkefeng.wang@...wei.com>,
 "Mark Brown" <broonie@...nel.org>,
 "Kevin Brodsky" <kevin.brodsky@....com>,
 "David Woodhouse" <dwmw@...zon.co.uk>,
 "Shakeel Butt" <shakeel.butt@...ux.dev>,
 "Alexei Starovoitov" <ast@...nel.org>, "Zi Yan" <ziy@...dia.com>,
 "Yu Zhao" <yuzhao@...gle.com>,
 "Baolin Wang" <baolin.wang@...ux.alibaba.com>, usamaarif642@...il.com,
 joel.granados@...nel.org, "Wei Yang" <richard.weiyang@...il.com>,
 "Geert Uytterhoeven" <geert+renesas@...der.be>,
 tim.c.chen@...ux.intel.com, linux <linux@...blig.org>,
 "Alexander Shishkin" <alexander.shishkin@...ux.intel.com>,
 lillian@...r-ark.net, "Huacai Chen" <chenhuacai@...nel.org>,
 francesco@...la.it, guoweikang.kernel@...il.com, link@...o.com,
 "Josh Poimboeuf" <jpoimboe@...nel.org>,
 "Masahiro Yamada" <masahiroy@...nel.org>,
 "Christian Brauner" <brauner@...nel.org>,
 Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 "Oleg Nesterov" <oleg@...hat.com>, "Mateusz Guzik" <mjguzik@...il.com>,
 "Andrii Nakryiko" <andrii@...nel.org>, wangfushuai@...du.com,
 linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-media@...r.kernel.org, linaro-mm-sig@...ts.linaro.org,
 linux-i2c@...r.kernel.org, Linux-Arch <linux-arch@...r.kernel.org>,
 linux-modules@...r.kernel.org, rcu <rcu@...r.kernel.org>,
 linux-nfs@...r.kernel.org, linux-rt-devel@...ts.linux.dev
Subject: Re: [PATCH v17 01/47] llist: move llist_{head,node} definition to types.h

On Thu, Oct 16, 2025, at 02:46, Byungchul Park wrote:
> On Fri, Oct 03, 2025 at 01:19:33AM +0200, Arnd Bergmann wrote:
>> On Thu, Oct 2, 2025, at 15:53, Mathieu Desnoyers wrote:
>> > On 2025-10-02 04:24, Greg KH wrote:
>> >> On Thu, Oct 02, 2025 at 05:12:01PM +0900, Byungchul Park wrote:

>> Maybe a shared linux/list_types.h would work, to specifically
>
> I found a way to resolve my issue, but I thought it's good idea
> regardless of my issue and took a quick look.  However, it seems like
> there's an overwhelming amount of work since it might require to replace
> all the existing include <linux/types.h> for use of list things with the
> new one :-).

I don't think it's that bad, since almost every header ends up
including linux/list.h indirectly at the moment.

A little bit of scripting to find the headers that reference
'struct list_head' but don't also include linux/list.h reveals
this relatively short set that would need to include the new
header:

> include/keys/asymmetric-parser.h
> include/linux/dynamic_debug.h
> include/linux/genalloc.h
> include/linux/gpio/machine.h
> include/linux/hiddev.h
> include/linux/iio/iio-opaque.h
> include/linux/iio/sysfs.h
> include/linux/input/touch-overlay.h
> include/linux/irq_poll.h
> include/linux/iscsi_boot_sysfs.h
> include/linux/kcore.h
> include/linux/kcsan-checks.h
> include/linux/kcsan.h
> include/linux/lockdep_types.h
> include/linux/logic_pio.h
> include/linux/maple.h
> include/linux/mfd/iqs62x.h
> include/linux/mlx5/macsec.h
> include/linux/mount.h
> include/linux/mtd/map.h
> include/linux/mtd/nand-qpic-common.h
> include/linux/mtd/partitions.h
> include/linux/mutex_types.h
> include/linux/nfs_fs_i.h
> include/linux/of_iommu.h
> include/linux/parport_pc.h
> include/linux/pinctrl/pinctrl.h
> include/linux/plist_types.h
> include/linux/pm_wakeup.h
> include/linux/reboot-mode.h
> include/linux/shm.h
> include/linux/smpboot.h
> include/linux/sunrpc/xprtmultipath.h
> include/linux/usb/audio.h
> include/linux/workqueue_types.h
> include/linux/zpool.h
> include/net/bluetooth/hci_sync.h
> include/net/bluetooth/l2cap.h
> include/net/bluetooth/rfcomm.h
> include/net/dcbnl.h
> include/sound/i2c.h
> include/sound/soc-jack.h
> include/target/iscsi/iscsi_transport.h
> include/video/udlfb.h

A lot of these don't have any #include statements at all,
which indicates that they expect to only be included in
places where the dependencies are already visible.

      Arnd

Powered by blists - more mailing lists