linux-kernel - Re: [PATCH v4 07/11] ASoC: cs530x: Add CODEC and DAC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0944336-e6e0-4ab2-95c3-be446e20230f@sirena.org.uk>
Date: Fri, 17 Oct 2025 17:41:35 +0100
From: Mark Brown <broonie@...nel.org>
To: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Takashi Iwai <tiwai@...e.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	David Rhodes <david.rhodes@...rus.com>,
	Richard Fitzgerald <rf@...nsource.cirrus.com>,
	Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com,
	devicetree@...r.kernel.org,
	Simon Trimmer <simont@...nsource.cirrus.com>
Subject: Re: [PATCH v4 07/11] ASoC: cs530x: Add CODEC and DAC support

On Fri, Oct 17, 2025 at 05:15:34PM +0100, Vitaly Rodionov wrote:

> --- a/sound/soc/codecs/cs530x.c
> +++ b/sound/soc/codecs/cs530x.c
> @@ -45,6 +45,18 @@ static const struct reg_default cs530x_reg_defaults[] = {
>  	{ CS530X_IN_VOL_CTRL3_1, 0x8000 },
>  	{ CS530X_IN_VOL_CTRL4_0, 0x8000 },
>  	{ CS530X_IN_VOL_CTRL4_1, 0x8000 },
> +	{ CS530X_OUT_ENABLES, 0 },
> +	{ CS530X_OUT_RAMP_SUM, 0x0022 },
> +	{ CS530X_OUT_FILTER, 0 },
> +	{ CS530X_OUT_INV, 0 },
> +	{ CS530X_OUT_VOL_CTRL1_0, 0x8000 },
> +	{ CS530X_OUT_VOL_CTRL1_1, 0x8000 },
> +	{ CS530X_OUT_VOL_CTRL2_0, 0x8000 },
> +	{ CS530X_OUT_VOL_CTRL2_1, 0x8000 },
> +	{ CS530X_OUT_VOL_CTRL3_0, 0x8000 },
> +	{ CS530X_OUT_VOL_CTRL3_1, 0x8000 },
> +	{ CS530X_OUT_VOL_CTRL4_0, 0x8000 },
> +	{ CS530X_OUT_VOL_CTRL4_1, 0x8000 },

Do these new registers apply to all parts or just some (I'm guessing
these might be different packaging/binnings of the same die in which
case this should be fine if a little messy, but just checking).

>  	/* Write IN_VU bit for the volume change to take effect */
> -	regmap_write(regmap, CS530X_IN_VOL_CTRL5, CS530X_IN_VU);
> +	regmap_write(regmap, CS530X_IN_VOL_CTRL5, CS530X_INOUT_VU);

The comment is now out of sync.  I can't help but feel that this change
might be easier to read if the rename of everything to INOUT were a
separate patch.

> +		cs530x->dac_pairs_count--;
> +		if (!cs530x->dac_pairs_count) {
> +			usleep_range(1000, 1100);
> +			return regmap_write(regmap, CS530X_OUT_VOL_CTRL5,
> +					    CS530X_INOUT_VU);
> +		}

Should dac_pairs_count be a supply widget?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)