linux-kernel - Re: [PATCH v4 09/11] ASoC: cs530x: Correct MCLK reference frequency values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPJ1hS-YD2M6nsJi@lonswws03.ad.cirrus.com>
Date: Fri, 17 Oct 2025 17:57:41 +0100
From: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
To: Mark Brown <broonie@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        David Rhodes <david.rhodes@...rus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
        linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4 09/11] ASoC: cs530x: Correct MCLK reference frequency
 values

On Fri, Oct 17, 2025 at 05:44:06PM +0100, Mark Brown wrote:
> On Fri, Oct 17, 2025 at 05:15:36PM +0100, Vitaly Rodionov wrote:
> > The MCLK frequency must be 49.152 MHz (for 48 kHz-related
> > sample rates) or 45.1584 MHz (for 44.1 kHz-related sample rates).
> 
> >  	switch (source) {
> >  	case CS530X_SYSCLK_SRC_MCLK:
> > -		if (freq != 24560000 && freq != 22572000) {
> > -			dev_err(component->dev, "Invalid MCLK source rate %d\n",
> > -				freq);
> > +		switch (freq) {
> > +		case CS530X_SYSCLK_REF_45_1MHZ:
> > +		case CS530X_SYSCLK_REF_49_1MHZ:
> > +			break;
> > +		default:
> > +			dev_err(component->dev, "Invalid MCLK source rate %d\n", freq);
> >  			return -EINVAL;
> >  		}
> >  		break;
> 
> This will break any existing user that sets MCLK won't it?  Hopefully
> they were managing to function, even if the clocks were out of spec.

Hopefully, there are no existing users yet. This was used only on our development board,
and we’d like to fix it proactively before any users encounter issues.