linux-kernel - Re: [PATCH v6 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <joong74bnb7by3ptmynxhbj2vdznp7b5u6ivlnm2tfu4rlplya@vvgfpcmm4f4i>
Date: Fri, 17 Oct 2025 22:39:30 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Cezar Chiru <chiru.cezar.89@...il.com>
Cc: wsa+renesas@...g-engineering.com, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/3] i2c: pcf8584: Fix errors and warnings reported by
 checkpatch

Hi Cezar,

can you please send your new version series as not
--in-reply-to?

I find it very confusing.

Thanks,
Andi

On Sat, Sep 27, 2025 at 07:13:57AM +0300, Cezar Chiru wrote:
> Hello maintainers,
> 
> This patch series fixes 18 errors and multiple warnings reported by 
> checkpatch.pl on drivers/i2c/algos/i2c-algo-pcf.c file.
> 
> The series PATCH v1 to PATCH v4 is a response to the discussion on the
> mailing list with Markus Elfring who had comments on my earlier 
> submissions. 
> He suggested:
>  -to split my initial submission in a patch series
>  -had some valid points on imperative mood usage in commit messages
>  -wrapping commit message to 75 columns per line
>  -change some of the commit message to point usage of checkpatch.pl
> The series PATCH v4 to PATCH v6 is a response to the discussion on the
> mailing list with I2C SUBSYSTEM maintainer Wolfram Sang who requested
> some changes:
> He requested:
>  - to remove debug macros from i2c-algo-pcf.c as no code change was done
>  for almost 16 years.
>  - remove wrapping paranthesis from value assigned of '(0)''.
>  - resolve conficts caused by debug macros removal.
>  - remove also printk and dev_dbg function calls related to DEB macros.
> 
> Here is a brief summary and order of patches to be applied:
> Patch 1/3: i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c
> This patch remove the define of debug macros and also their usage from
> code along with printk and dev_dbg function calls.
> 
> Patch 2/3: i2c: pcf8584: Fix do not use assignment inside if conditional
> This patch takes the assignement from if conditional and moves it by 1 line
> up.
> 
> Patch 3/3: i2c: pcf8584: Fix space(s) required before or after different
>            operators
> This patch adds space(s) around some binary operators.
> 
> Testing:
>    *built kernel and modules with I2C_ALGOPCF=m and my 3 patches applied on
>    top of 6.17.0-rc7.
>    *installed kernel and external modules generated by build on my laptop
>    *rebooted and loaded i2c-algo-pcf.ko without i2c_debug parameter.
>    *when loading the .ko with i2c_debug parameter an error is seen in dmesg
>    and this is expected as the parameter was removed.
>    *No success message related to i2c_algo_pcf was seen in dmesg but also 
>    no failures.
>    *Module loading and unloading successful.
>    *No PCF8584 Hardware was available.
> 
> Cezar Chiru (3):
>   i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c
>   i2c: pcf8584: Fix do not use assignment inside if conditional
>   i2c: pcf8584: Fix space(s) required before or after different
>     operators
> 
>  drivers/i2c/algos/i2c-algo-pcf.c | 93 +++++++-------------------------
>  1 file changed, 18 insertions(+), 75 deletions(-)
> 
> -- 
> 2.43.0
>