linux-kernel - Re: [PATCH v6 1/3] i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vop42qhict2oqppb6ozg46fxwwwk5egp2po4rlnxhhjlt4xojc@yq77b2qmx6eq>
Date: Fri, 17 Oct 2025 22:47:52 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Cezar Chiru <chiru.cezar.89@...il.com>
Cc: wsa+renesas@...g-engineering.com, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/3] i2c: pcf8584: Remove debug macros from
 i2c-algo-pcf.c

Hi Cezar,

On Sat, Sep 27, 2025 at 07:13:58AM +0300, Cezar Chiru wrote:
> Remove debug macros and printk and dev_debg function calls from file
> as no change was done for 16 years.

You have also removed the module parameter.

> Request by I2C SUBSYSTEM maintainer Wolfram Sang.

Please, remove this last sentence, it's not a useful information
to add in a git log. You can either add it in the cover letter or
after the "---" section. I'd say in the cover letter as you have
already done.

The patch looks good. Thanks for taking care of it.

Andi