linux-kernel - Re: [PATCH v2 2/2] docs: checkpatch: Drop networking comment style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4eaf960-b21b-475e-955c-b40f0adbfbf5@infradead.org>
Date: Fri, 17 Oct 2025 14:16:26 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Brian Norris <briannorris@...omium.org>,
 Dwaipayan Ray <dwaipayanray1@...il.com>,
 Lukas Bulwahn <lukas.bulwahn@...il.com>, Jonathan Corbet <corbet@....net>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 Joe Perches <joe@...ches.com>, workflows@...r.kernel.org
Subject: Re: [PATCH v2 2/2] docs: checkpatch: Drop networking comment style



On 10/17/25 1:37 PM, Brian Norris wrote:
> Networking no longer has their own comment style, and checkpatch no
> longer checks for this.
> 
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> Suggested-by: Randy Dunlap <rdunlap@...radead.org>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

and for reference:

commit 82b8000c28b5
Author: Johannes Berg <johannes.berg@...el.com>
Date:   Mon Aug 19 11:09:43 2024 +0200
    net: drop special comment style


Thanks.

> ---
> 
> Changes in v2:
>  * new in v2
> 
>  Documentation/dev-tools/checkpatch.rst | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
> index d7fe023b3080..dfaad0a279ff 100644
> --- a/Documentation/dev-tools/checkpatch.rst
> +++ b/Documentation/dev-tools/checkpatch.rst
> @@ -465,13 +465,6 @@ Comments
>         * for multi line comments.
>         */
>  
> -    The networking comment style is a bit different, with the first line
> -    not empty like the former::
> -
> -      /* This is the preferred comment style
> -       * for files in net/ and drivers/net/
> -       */
> -
>      See: https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
>  
>    **C99_COMMENTS**

-- 
~Randy