linux-kernel - Re: [PATCH V4 4/4] media: ti: vpe: Add the VIP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8554dfe1-6dec-49b4-9c34-e51bd4e28404@kernel.org>
Date: Fri, 17 Oct 2025 07:23:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yemike Abhilash Chandra <y-abhilashchandra@...com>, mchehab@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 hverkuil+cisco@...nel.org
Cc: sakari.ailus@...ux.intel.com, bparrot@...com,
 jai.luthra@...asonboard.com, dale@...nsworth.org,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, u-kumar1@...com,
 Sukrut Bellary <sbellary@...libre.com>
Subject: Re: [PATCH V4 4/4] media: ti: vpe: Add the VIP driver

On 17/10/2025 07:19, Krzysztof Kozlowski wrote:
> On 15/10/2025 07:40, Yemike Abhilash Chandra wrote:
>> +static int vip_probe_complete(struct platform_device *pdev)
>> +{
>> +	struct vip_shared *shared = platform_get_drvdata(pdev);
>> +	struct vip_ctrl_module *ctrl = NULL;
>> +	struct vip_port *port;
>> +	struct vip_dev *dev;
>> +	struct device_node *parent = pdev->dev.of_node;
>> +	struct fwnode_handle *ep = NULL;
>> +	struct of_phandle_args args;
>> +	int ret, i, slice_id, port_id, p;
>> +
>> +	/* Allocate ctrl before using it */
>> +	ctrl = devm_kzalloc(&pdev->dev, sizeof(*ctrl), GFP_KERNEL);
>> +	if (!ctrl)
>> +		return -ENOMEM;
>> +
>> +	if (parent && of_property_present(parent, "ti,ctrl-module")) {
>> +		ctrl->syscon_pol = syscon_regmap_lookup_by_phandle(parent,
>> +								   "ti,ctrl-module");
>> +		if (IS_ERR(ctrl->syscon_pol))
>> +			return dev_err_probe(&pdev->dev, PTR_ERR(ctrl->syscon_pol),
>> +				     "Failed to get ti,ctrl-module regmap\n");
>> +	}
>> +
>> +	ret = of_parse_phandle_with_fixed_args(parent, "ti,ctrl-module",
>> +					       5, 0, &args);
> 
> 1. You leak parent.


I meant args->np, obviously.

> 2. Why you can't just just take it from syscon call? This is not only
> leaking, but actually duplicated and unnecessary.
> 
>> +
Best regards,
Krzysztof