linux-kernel - Re: [PATCH V4 3/4] dt-bindings: media: ti: vpe: Add support for Video Input Port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251021-small-fascinating-dachshund-c4227e@kuoka>
Date: Tue, 21 Oct 2025 08:46:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yemike Abhilash Chandra <y-abhilashchandra@...com>
Cc: mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, hverkuil+cisco@...nel.org, sakari.ailus@...ux.intel.com, 
	bparrot@...com, jai.luthra@...asonboard.com, dale@...nsworth.org, 
	linux-media@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	u-kumar1@...com, Sukrut Bellary <sbellary@...libre.com>
Subject: Re: [PATCH V4 3/4] dt-bindings: media: ti: vpe: Add support for
 Video Input Port

On Wed, Oct 15, 2025 at 11:10:09AM +0530, Yemike Abhilash Chandra wrote:
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    vip1: video@...70000 {

Drop label, while at it.

> +        compatible = "ti,dra7-vip";
> +        reg = <0x48970000 0x1000>;
> +        interrupts = <GIC_SPI 351 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SPI 392 IRQ_TYPE_LEVEL_HIGH>;
> +        ti,ctrl-module = <&scm_conf 0x534 0x0 0x2 0x1 0x3>;
> +
> +        ports {
> +              #address-cells = <1>;

You still have completely messed up indentation.

> +              #size-cells = <0>;
> +
> +              vin1a: port@0 {
> +                    reg = <0>;
> +
> +                    vin1a_ep: endpoint {

Best regards,
Krzysztof