linux-kernel - Re: [PATCH v5] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for audio blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08f52331-baa1-45ef-bfb8-dc6db000ceff@kernel.org>
Date: Fri, 17 Oct 2025 09:43:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexey Klimov <alexey.klimov@...aro.org>, lee@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, sboyd@...nel.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, srini@...nel.org,
 krzysztof.kozlowski@...aro.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH v5] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for
 audio blocks

On 17/10/2025 08:45, Alexey Klimov wrote:
> On Fri Oct 17, 2025 at 7:25 AM BST, Krzysztof Kozlowski wrote:
>> On 17/10/2025 08:13, Alexey Klimov wrote:
>>> If/when pm4125 audio codec will be added to a device tree file, then dtbs
>>> check will emit messages that pmic audio-codec@...0 doesn't match any
>>> of the regexes: '^pinctrl-[0-9]+$'.
>>
>>
>> Future errors because of present mistakes are not a reason to do
>> something. This makes no sense because there is no DTBs with that
>> compatible, so drop this sentence. We never document compatibles,
>> because in the future they will be errors (if I get it right?).
> 
> Ok. I can hold it off till it will be started to be used then.

No, you don't get the point. You invented fake (future) error as
rationale... and want to wait till there is real error to commit this?
This makes no sense.

You need to provide rationale for this patch - look at every other commit.

Best regards,
Krzysztof