linux-kernel - Re: [PATCH] arm64: defconfig: Change CONFIG_SM_TCSRCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94ae58e4-4fd2-4c29-a060-986d84309f94@kernel.org>
Date: Fri, 17 Oct 2025 10:34:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Taniya Das <quic_tdas@...cinc.com>, Taniya Das
 <taniya.das@....qualcomm.com>, Bjorn Andersson <andersson@...nel.org>,
 linux-arm-msm@...r.kernel.org
Cc: linux-arm-kernel@...ts.infradead.org,
 Ajit Pandey <ajit.pandey@....qualcomm.com>,
 Imran Shaik <imran.shaik@....qualcomm.com>,
 Jagadeesh Kona <jagadeesh.kona@....qualcomm.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: defconfig: Change CONFIG_SM_TCSRCC_8750 from m to
 y

On 17/10/2025 10:15, Konrad Dybcio wrote:
> On 10/17/25 8:54 AM, Krzysztof Kozlowski wrote:
>> On 17/10/2025 07:56, Krzysztof Kozlowski wrote:
>>> On 17/10/2025 07:49, Taniya Das wrote:
>>>>
>>>>
>>>> On 10/17/2025 10:51 AM, Krzysztof Kozlowski wrote:
>>>>> On 17/10/2025 07:16, Taniya Das wrote:
> 
> [...]
> 
>>>> We have tried booting up recently and and that is what we observed. The
>>>> patch from 'm' to 'y' helps the UFS probe is successful and the rootfs
>>>> is picked from ufs partitions. I will add these fail & success log
>>>> snippets in the commit text.
>>>
>>> That's not enough. You need to explain why UFS fails. After explaining
>>> this, I guess bug in UFS would be exposed thus that one should be fixed.
>>> You just provided band-aid without fixing the real problem.
>>>
>>> NAK
>>
>>
>> ... and to prove your analysis is wrong (because your setup is likely
>> having issues) I even tested now linux next with defconfig. Works all
>> fine on next-20251013. You did not share which kernel even has this
>> issue, maybe some downstream tree?
> 
> Is there a chance you have the TCSR module packed in initramfs and
> Taniya doesn't?

Of course that's a chance, since I have all modules packed. Why would
someone pack UFS to initramfs but not its dependencies? It would never
work, actually, nothing would work...

If initramfs does not have necessary modules, way to fix it is to add
these modules, not make the symbol enabled.

Best regards,
Krzysztof