linux-kernel - Re: [PATCH v5 09/14] gpu: nova-core: Add bindings and accessors for GspSystemInfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DDK7R7X621Y7.4D5CSTY8BOG2@nvidia.com>
Date: Fri, 17 Oct 2025 10:41:29 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Alistair Popple" <apopple@...dia.com>, "Alexandre Courbot"
 <acourbot@...dia.com>
Cc: <rust-for-linux@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
 <dakr@...nel.org>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "David Airlie" <airlied@...il.com>,
 "Simona Vetter" <simona@...ll.ch>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "John Hubbard"
 <jhubbard@...dia.com>, "Joel Fernandes" <joelagnelf@...dia.com>, "Timur
 Tabi" <ttabi@...dia.com>, <linux-kernel@...r.kernel.org>,
 <nouveau@...ts.freedesktop.org>
Subject: Re: [PATCH v5 09/14] gpu: nova-core: Add bindings and accessors for
 GspSystemInfo

On Fri Oct 17, 2025 at 9:56 AM JST, Alistair Popple wrote:
> On 2025-10-16 at 17:24 +1100, Alexandre Courbot <acourbot@...dia.com> wrote...
>> On Mon Oct 13, 2025 at 3:20 PM JST, Alistair Popple wrote:
>> > Adds bindings and an in-place initialiser for the GspSystemInfo struct.
>> >
>> > Signed-off-by: Alistair Popple <apopple@...dia.com>
>> 
>> I am getting a new unused warnings on this patch - we should either
>> annotate or merge.
>
> Yeah there are quite a few unused warnings. They're a pain to deal with during
> patch revisions and rebasing/rewriting so I was waiting until all the comments
> settled down before dealing with them as it's pretty tedious work adding lint
> statements in one patch and removing them in the next.
>
> As you say the easiest solution is just to merge patches, but that just promotes
> larger patches. I wish we didn't have to make that trade off, but I guess if we
> want clippy bisection to be clean we have to.
>
> I will probably just merge all the bindings into the patches that use them.

Miguel's suggestion of adding a temporary, file-global `expect(unused)`
directive would also work very well if you want to preserve the patch
sequence.