linux-kernel - Re: [PATCH v2 03/24] MIPS: PCI: Use pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPIyaPuTXEfBPHme@alpha.franken.de>
Date: Fri, 17 Oct 2025 14:11:20 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: "Maciej W. Rozycki" <macro@...am.me.uk>,
	Guenter Roeck <linux@...ck-us.net>,
	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 03/24] MIPS: PCI: Use pci_enable_resources()

On Fri, Oct 17, 2025 at 01:58:13PM +0300, Ilpo Järvinen wrote:
> On Fri, 17 Oct 2025, Thomas Bogendoerfer wrote:
> 
> > On Tue, Oct 14, 2025 at 03:41:42PM +0300, Ilpo Järvinen wrote:
> > > [...]
> > > It was "good enough" only because the arch specific 
> > > pcibios_enable_resources() was lacking the check for whether the resource 
> > > truly got assigned or not. The PIIX4 driver must worked just fine without 
> > > those IO resources which is what most drivers do despite using 
> > > pci(m)_enable_device() and not pci_enable_device_mem() (the latter 
> > > doesn't even seem to come with m variant).
> > 
> > will you send a v2 of the patch ?
> 
> Without the the if ()? I can do that, I was unsure how people wanted to 
> progress with this.

yes without the if(), thank you

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]