linux-kernel - Re: [PATCH] irqchip/qcom-irq-combiner: Rename driver structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sefhzn18.ffs@tglx>
Date: Fri, 17 Oct 2025 15:16:19 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Johan Hovold <johan@...nel.org>
Cc: linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH] irqchip/qcom-irq-combiner: Rename driver structure

On Fri, Oct 17 2025 at 07:52, Johan Hovold wrote:
> The "_probe" suffix of the driver structure name prevents modpost from
> warning about section mismatches so replace it to catch any future
> issues like the recently fixed probe function being incorrectly marked
> as __init.

I take this grudgingly, but not without pointing out again that this is
just a horrible hack. Why can't this stuff be properly annotated and
recorded in a throwaway section so that modpost can act on reliable data
instead of using string matching on arbitrary function names?

Thanks,

        tglx