linux-kernel - Re: [PATCH] btrfs: initialize folios to NULL in compress_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97fc4d4c-2142-45f3-b1a9-4b4f3bd3d21c@gmx.com>
Date: Sun, 19 Oct 2025 19:42:40 +1030
From: Qu Wenruo <quwenruo.btrfs@....com>
To: Kriish Sharma <kriish.sharma2006@...il.com>, clm@...com, dsterba@...e.com
Cc: linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org, david.hunter.linux@...il.com,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] btrfs: initialize folios to NULL in compress_file_range()



在 2025/10/19 19:06, Kriish Sharma 写道:
> The variable 'folios' may be used uninitialized when jumping to cleanup
> labels, triggering the following clang warning:
> 
>    fs/btrfs/inode.c:874:6: warning: variable 'folios' is used uninitialized
>    whenever 'if' condition is true
> 
> Initialize 'folios' to NULL to ensure the cleanup path is safe and to
> silence the compiler warning.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510171743.VQ6yA0Uu-lkp@intel.com/
> Signed-off-by: Kriish Sharma <kriish.sharma2006@...il.com>

Before the LKP report it's already fixed in the for-next branch.

> ---
>   fs/btrfs/inode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index d726bcdacf6b..54903e17338f 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -862,7 +862,7 @@ static void compress_file_range(struct btrfs_work *work)
>   	u64 actual_end;
>   	u64 i_size;
>   	int ret = 0;
> -	struct folio **folios;
> +	struct folio **folios = NULL;
>   	unsigned long nr_folios;
>   	unsigned long total_compressed = 0;
>   	unsigned long total_in = 0;