linux-kernel - Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6f9cfc9-b26e-4358-8781-6ce75075d13f@linaro.org>
Date: Mon, 20 Oct 2025 17:58:40 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Timothy Pearson <tpearson@...torengineering.com>, robh <robh@...nel.org>
Cc: devicetree <devicetree@...r.kernel.org>,
 linux-kernel <linux-kernel@...r.kernel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Lee Jones <lee@...nel.org>, Georgy Yakovlev <Georgy.Yakovlev@...y.com>,
 Shawn Anastasio <sanastasio@...torengineering.com>
Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

On 20/10/2025 17:34, Timothy Pearson wrote:
>>> +  watchdog:
>>> +    type: object
>>> +    description: Cronos Platform Watchdog Timer
>>> +
>>> +    allOf:
>>> +      - $ref: watchdog.yaml#
>>> +
>>> +    properties:
>>> +      compatible:
>>> +        const: sony,cronos-watchdog
>>
>> There's no need for a child node here. 'timeout-sec' can just go in the
>> parent node.
> 
> Could you elaborate on this please?  As far as I can tell we ref watchdog.yaml and need some kind of compatible string, so why would I break out timeout-sec directly here?


Please look where the comment was placed. Under $ref? No. Under this
compatible. $ref goes to the parent, obviously.

You do not need kind of compatible string. Parent already has one. You
do not need compatible strings at all to instantiate Linux drivers.
That's pretty common pattern for most of MFD-like devices, plenty of
examples in the kernel.


Best regards,
Krzysztof