lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1626454153.1801886.1760976086710.JavaMail.zimbra@raptorengineeringinc.com>
Date: Mon, 20 Oct 2025 11:01:26 -0500 (CDT)
From: Timothy Pearson <tpearson@...torengineering.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: robh <robh@...nel.org>, devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	Conor Dooley <conor+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
	Lee Jones <lee@...nel.org>, 
	Georgy Yakovlev <Georgy.Yakovlev@...y.com>
Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld



----- Original Message -----
> From: "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>
> To: "Timothy Pearson" <tpearson@...torengineering.com>, "robh" <robh@...nel.org>
> Cc: "devicetree" <devicetree@...r.kernel.org>, "linux-kernel" <linux-kernel@...r.kernel.org>, "Conor Dooley"
> <conor+dt@...nel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>, "Lee Jones" <lee@...nel.org>, "Georgy
> Yakovlev" <Georgy.Yakovlev@...y.com>, "Shawn Anastasio" <sanastasio@...torengineering.com>
> Sent: Monday, October 20, 2025 10:58:40 AM
> Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

> On 20/10/2025 17:34, Timothy Pearson wrote:
>>>> +  watchdog:
>>>> +    type: object
>>>> +    description: Cronos Platform Watchdog Timer
>>>> +
>>>> +    allOf:
>>>> +      - $ref: watchdog.yaml#
>>>> +
>>>> +    properties:
>>>> +      compatible:
>>>> +        const: sony,cronos-watchdog
>>>
>>> There's no need for a child node here. 'timeout-sec' can just go in the
>>> parent node.
>> 
>> Could you elaborate on this please?  As far as I can tell we ref watchdog.yaml
>> and need some kind of compatible string, so why would I break out timeout-sec
>> directly here?
> 
> 
> Please look where the comment was placed. Under $ref? No. Under this
> compatible. $ref goes to the parent, obviously.

This is not an area of the kernel I'm normally changing, so I appreciate the insight.  None of this yaml syntax is particularly obvious the first time it's encountered, at least not to me.

> You do not need kind of compatible string. Parent already has one. You
> do not need compatible strings at all to instantiate Linux drivers.
> That's pretty common pattern for most of MFD-like devices, plenty of
> examples in the kernel.

Understood.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ