linux-kernel - Re: [PATCH v1] selftests: cachestat: Fix warning on declaration under label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKEwX=PBrcPnEkEhWQn_CTtT04qaKY2WsWXjDSSyPUGX4yY-sw@mail.gmail.com>
Date: Mon, 20 Oct 2025 10:13:07 -0700
From: Nhat Pham <nphamcs@...il.com>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: hannes@...xchg.org, nathan@...nel.org, shuah@...nel.org, morbo@...gle.com, 
	justinstitt@...gle.com, nick.desaulniers+lkml@...il.com, linux-mm@...ck.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org, 
	llvm@...ts.linux.dev, david.hunter.linux@...il.com, 
	Sidharth Seela <sidharthseela@...il.com>, SeongJae Park <sj@...nel.org>
Subject: Re: [PATCH v1] selftests: cachestat: Fix warning on declaration under label

On Fri, Oct 10, 2025 at 1:07 PM Shuah Khan <skhan@...uxfoundation.org> wrote:
>
> On 9/29/25 11:27, SeongJae Park wrote:
> > On Mon, 29 Sep 2025 17:24:06 +0530 Sidharth Seela <sidharthseela@...il.com> wrote:
> >
> >> Fix warning caused from declaration under a case label. The proper way
> >> is to declare variable at the beginning of the function. The warning
> >> came from running clang using LLVM=1; and is as follows:
> >> --
> >> -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
> >>    260 |                 char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
> >>        |
> >>
> >> Signed-off-by: Sidharth Seela <sidharthseela@...il.com>
> >
> > Reviewed-by: SeongJae Park <sj@...nel.org>
> >
> >
>
> Johannes and Nhat,
>
> Assuming this will go through cachestat tree
>
> Acked-by: Shuah Khan <skhan@...uxfoundation.org>
>

Hi Shuah.

LGTM:
Acked-by: Nhat Pham <nphamcs@...il.com>