lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cb30af9e-c22b-485a-a83c-f395880cd799@linuxfoundation.org>
Date: Wed, 22 Oct 2025 09:27:23 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Dev Jain <dev.jain@....com>, Sidharth Seela <sidharthseela@...il.com>,
 nphamcs@...il.com, hannes@...xchg.org, nathan@...nel.org, shuah@...nel.org,
 morbo@...gle.com, justinstitt@...gle.com, nick.desaulniers+lkml@...il.com
Cc: linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
 david.hunter.linux@...il.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v1] selftests: cachestat: Fix warning on declaration under
 label

On 9/29/25 22:52, Dev Jain wrote:
> 
> On 29/09/25 5:24 pm, Sidharth Seela wrote:
>> Fix warning caused from declaration under a case label. The proper way
>> is to declare variable at the beginning of the function. The warning
>> came from running clang using LLVM=1; and is as follows:
>> -- 

Sidharth,

Make sure to not use "---" in your commit logs. Everything after
this line gets thrown away. I had to go fix it manually.

>> -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
>>    260 |                 char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE,
>>        |
>>
>> Signed-off-by: Sidharth Seela <sidharthseela@...il.com>
>> ---
>>
> 
> Reviewed-by: Dev Jain <dev.jain@....com>
> 
Applied to linux-kselftest fixes branch for next rc.

thanks,
-- Shuah

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ