linux-kernel - Re: [PATCH v3 2/4] dt-bindings: leds: Add virtualcolor group dt bindings documentation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
	<TY4PR01MB17309CB1B7797B52FF031A27EF0F5A@TY4PR01MB17309.jpnprd01.prod.outlook.com>
Date: Mon, 20 Oct 2025 18:00:47 +0000
From: jonathan brophy <professorjonny98@...il.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: Jonathan Brophy <Professor_jonny@...mail.com>, Pavel Machek
	<pavel@...nel.org>, "linux-leds@...r.kernel.org"
	<linux-leds@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Conor Dooley
	<conor+dt@...nel.org>, Radoslav Tsvetkov <rtsvetkov@...dotech.eu>, lee Jones
	<lee@...nel.org>
Subject: Re: [PATCH v3 2/4] dt-bindings: leds: Add virtualcolor group dt
 bindings documentation.




On Sun, 21 October 2025 12:35 AM, JRob Herring (Arm) wrote:
>
>
>On Sun, 19 Oct 2025 22:23:25 +1300, Jonathan Brophy wrote:>
>
> From: Jonathan Brophy <professor_jonny@...mail.com>
>
>
>
>> Add device tree binding documentation for the virtual LED group driver
>>
>> that implements virtual LED groups by aggregating multiple monochromatic
>>
>> LEDs
>>
>>
>
>> Bindings for the virtual driver are not describing hardware LEDs they
>
>> describe virtual devices made from groups of hardware LEDs created from an array
>
>> of LED phandles.
>
>
>
>> Normally the device tree is used to describe hardware not virtual hardware
>
>> but it is particularly useful in situations where you require an LED to be a
>
>> specific color by mixing primary colors, such as multi element multi color LEDs
>
>> to be operated from a device tree binding.
>
>
>> It also becomes useful with multiple LEDs operating the same indicator such as
>
>> ring of light indicators where the LEDs are driven From different GPIO outputs
>
>> unifying the control that can give basic indication during system startup,
>
>> shutdown upgrade etc...
>
>>
>
>> co-developed-by: Radoslav Tsvetkov <rtsvetkov@...dotech.eu>
>
>> Signed-off-by: Radoslav Tsvetkov <rtsvetkov@...dotech.eu>
>
>> Signed-off-by: Jonathan Brophy <professor_jonny@...mail.com>
>
>> ---
>
>>  .../leds/leds-group-virtualcolor.yaml         | 110 ++++++++++++++++++
>
>>  1 file changed, 110 insertions(+)
>
>>  create mode 100644 Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml
>
>
>My bot found errors running 'make dt_binding_check' on your patch:
>
>
>
>yamllint warnings/errors:
>
>
>
>dtschema/dtc warnings/errors:
>
>/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led->controller (pwm-leds): led-1: 'max-brightness' is a required property
>
>       from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
>
>/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led->controller (pwm-leds): led-2: 'max-brightness' is a required property
>
>       from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
>
>/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led->controller (pwm-leds): led-3: 'max-brightness' is a required property
>
>       from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
>
>/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.example.dtb: pwm-led->controller (pwm-leds): led-4: 'max-brightness' is a required property
>
>      from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
>

sorry this was me checking my yaml's without validating the whole structure as those are covered by their own Yaml's
In futurre I will validate the whole structure.