[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<TY4PR01MB17309F84122EF932A5C62C575F0F5A@TY4PR01MB17309.jpnprd01.prod.outlook.com>
Date: Mon, 20 Oct 2025 18:56:39 +0000
From: jonathan brophy <professorjonny98@...il.com>
To: Alexander Dahl <ada@...rsis.com>, Jacek Anaszewski
<jacek.anaszewski@...il.com>
CC: lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>, Jonathan
Brophy <Professor_jonny@...mail.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Radoslav Tsvetkov <rtsvetkov@...dotech.eu>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-leds@...r.kernel.org"
<linux-leds@...r.kernel.org>
Subject: Re: [PATCH v3 0/4] leds: Add a virtual LED driver for groups of
Hi Alexander
>
>From: Alexander Dahl <ada@...rsis.com>
>Sent: Monday, October 20, 2025 9:40 PM
>
>Hei Jacek,
>
>
>
>Am Sun, Oct 19, 2025 at 04:24:38PM +0200 schrieb Jacek Anaszewski:
>
>> Hi Jonathan,
>
>>
>
>> On 10/19/25 11:23, Jonathan Brophy wrote:
>
>> > From: Jonathan Brophy <professor_jonny@...mail.com>
>
>> > Introduce a new driver that implements virtual LED groups,
>
>> > aggregating multiple monochromatic LEDs into virtual groups and providing
>
>> > priority-based control for concurrent state management.
>
>
>> Aren't you trying to reinvent LED trigger mechanism?
>
>
>
>Instead of using virtual LEDs, could this be implemented as a
>
>"virtual" trigger which allows grouping (and prioritizing) multiple
>
>other triggers, and apply that to only one existing LED?
>
>
>
>Greets
>
>Alex
I looked at this you would have to include priority for each virtual trigger and it would
get very hard to understand very quickly.
then things like per channel color for each trigger etc would just be impossible to implement..
it would need a way to map and display it logically under sysfs too.
For example the additive RGB color wheel has 3 primary colors if you have a solid and a blink for each primary and secondary color that is 8 triggers for a single led.
I'm basically following the similar structure of leds-group-multicolor where they
in effect create a new structure representing individual led elements but, instead
of displaying the properties of the parent items, I'm creating new virtual properties
that of the group in the form of a single virtual LED or a multi LED.
Powered by blists - more mailing lists