linux-kernel - Re: [PATCH net-next] net: phy: micrel: Add support for non PTP SKUs for lan8814

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0a8830e-6267-4b2a-b1fa-f3cbe34bd3ba@engleder-embedded.com>
Date: Mon, 20 Oct 2025 20:11:13 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, andrew@...n.ch,
 hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 richardcochran@...il.com
Subject: Re: [PATCH net-next] net: phy: micrel: Add support for non PTP SKUs
 for lan8814

On 20.10.25 08:39, Horatiu Vultur wrote:
> The 10/17/2025 23:15, Gerhard Engleder wrote:

...

>>>
>>> +/* Check if the PHY has 1588 support. There are multiple skus of the PHY and
>>> + * some of them support PTP while others don't support it. This function will
>>> + * return true is the sku supports it, otherwise will return false.
>>> + */
>>
>> Hasn't net also switched to the common kernel multiline comment style
>> starting with an empty line?
> 
> I am not sure because I can see some previous commits where people used
> the same comment style:
> e82c64be9b45 ("net: stmmac: avoid PHY speed change when configuring MTU")
> 100dfa74cad9 ("net: dev_queue_xmit() llist adoption")

The special coding style for multi line comments for net and drivers/net 
has been removed with
82b8000c28 ("net: drop special comment style")

But I checked a few mails on the list and also found the old style in
new patches.

Gerhard