linux-kernel - Re: [PATCH 2/8] dt-bindings: spi: fsl-qspi: support SpacemiT K1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251020-florist-campus-a397bf94d129@spud>
Date: Mon, 20 Oct 2025 19:39:48 +0100
From: Conor Dooley <conor@...nel.org>
To: Mark Brown <broonie@...nel.org>
Cc: Alex Elder <elder@...cstar.com>, han.xu@....com, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, dlan@...too.org,
	guodong@...cstar.com, devicetree@...r.kernel.org,
	linux-spi@...r.kernel.org, imx@...ts.linux.dev,
	spacemit@...ts.linux.dev, linux-riscv@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] dt-bindings: spi: fsl-qspi: support SpacemiT K1

On Mon, Oct 20, 2025 at 07:26:17PM +0100, Mark Brown wrote:
> On Mon, Oct 20, 2025 at 01:06:46PM -0500, Alex Elder wrote:
> > On 10/20/25 12:39 PM, Conor Dooley wrote:
> 
> > > > +          - spacemit,k1-qspi
> 
> > > Are the newly added resets mandatory for the spacemit platform?
> 
> > This is interesting.  I never even tried it without specifying them.
> 
> > I just tried it, and at least on my system QSPI functioned without
> > defining these resets.  I will ask SpacemiT about this.  If they are
> > not needed I will omit the first patch (which added optional resets),
> > and won't use them.
> 
> It might be safer to describe them, otherwise things are vulnerable to
> issues like the bootloader not leaving things in a predictable state.

Yeah, if a linux driver requires that a bootloader set up a clock or
de-assert a reset etc, then the binding should mark them required since,
as you say, a bootloader change might do away with that de-assertion.
Additionally, the stage doing that de-assertion etc could be U-Boot
or barebox, which import devicetrees from Linux, so making sure that
the resets are present has that benefit too.


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)