linux-kernel - Re: [PATCH 3/8] spi: fsl-qspi: add optional reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPaIezCu/gXxJC01@lizhi-Precision-Tower-5810>
Date: Mon, 20 Oct 2025 15:07:39 -0400
From: Frank Li <Frank.li@....com>
To: Alex Elder <elder@...cstar.com>
Cc: han.xu@....com, broonie@...nel.org, p.zabel@...gutronix.de,
	dlan@...too.org, guodong@...cstar.com, linux-spi@...r.kernel.org,
	imx@...ts.linux.dev, spacemit@...ts.linux.dev,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] spi: fsl-qspi: add optional reset support

On Mon, Oct 20, 2025 at 11:51:46AM -0500, Alex Elder wrote:
> Add support for one or more optional exclusive resets.  These
> simply need to be deasserted at probe time, and can remain that
> way for the life of the device.

Nit: please wrap at 75 chars

Reviewed-by: Frank Li <Frank.Li@....com>

>
> Signed-off-by: Alex Elder <elder@...cstar.com>
> ---
>  drivers/spi/spi-fsl-qspi.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c
> index c887abb028d77..1e27647dd2a09 100644
> --- a/drivers/spi/spi-fsl-qspi.c
> +++ b/drivers/spi/spi-fsl-qspi.c
> @@ -36,6 +36,7 @@
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_qos.h>
> +#include <linux/reset.h>
>  #include <linux/sizes.h>
>
>  #include <linux/spi/spi.h>
> @@ -267,6 +268,7 @@ struct fsl_qspi {
>  	const struct fsl_qspi_devtype_data *devtype_data;
>  	struct mutex lock;
>  	struct completion c;
> +	struct reset_control *resets;
>  	struct clk *clk, *clk_en;
>  	struct pm_qos_request pm_qos_req;
>  	struct device *dev;
> @@ -857,6 +859,8 @@ static void fsl_qspi_cleanup(void *data)
>  {
>  	struct fsl_qspi *q = data;
>
> +	reset_control_assert(q->resets);
> +
>  	fsl_qspi_clk_disable_unprep(q);
>
>  	mutex_destroy(&q->lock);
> @@ -902,6 +906,10 @@ static int fsl_qspi_probe(struct platform_device *pdev)
>  	if (!q->ahb_addr)
>  		return -ENOMEM;
>
> +	q->resets = devm_reset_control_array_get_optional_exclusive(dev);
> +	if (IS_ERR(q->resets))
> +		return PTR_ERR(q->resets);
> +
>  	/* find the clocks */
>  	q->clk_en = devm_clk_get(dev, "qspi_en");
>  	if (IS_ERR(q->clk_en))
> @@ -923,6 +931,10 @@ static int fsl_qspi_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>
> +	ret = reset_control_deassert(q->resets);
> +	if (ret)
> +		return ret;
> +
>  	/* find the irq */
>  	ret = platform_get_irq(pdev, 0);
>  	if (ret < 0)
> --
> 2.48.1
>