linux-kernel - Re: [PATCH net v4 2/2] phy: mscc: Fix PTP for VSC8574 and VSC8572

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251020165346.276cd17e@kernel.org>
Date: Mon, 20 Oct 2025 16:53:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <andrew@...n.ch>
Cc: Horatiu Vultur <horatiu.vultur@...rochip.com>, <hkallweit1@...il.com>,
 <linux@...linux.org.uk>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <richardcochran@...il.com>, <vladimir.oltean@....com>,
 <vadim.fedorenko@...ux.dev>, <rmk+kernel@...linux.org.uk>,
 <christophe.jaillet@...adoo.fr>, <rosenp@...il.com>,
 <steen.hegelund@...rochip.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v4 2/2] phy: mscc: Fix PTP for VSC8574 and VSC8572

On Fri, 17 Oct 2025 08:48:19 +0200 Horatiu Vultur wrote:
> For VSC8574 and VSC8572, the PTP initialization is incomplete. It is
> missing the first part but it makes the second part. Meaning that the
> ptp_clock_register() is never called.
> 
> There is no crash without the first part when enabling PTP but this is
> unexpected because some PHys have PTP functionality exposed by the
> driver and some don't even though they share the same PTP clock PTP.

I'm tempted to queue this to net-next, sounds like a "never worked 
in an obvious way" case.  I'd appreciate a second opinion.. Andrew?