linux-kernel - Re: [PATCH v3 12/22] smb: move some duplicate definitions to common/cifspdu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd8j6LjAvzBvKh9N3nvtqacLwLQ24sHKHu2Wh3vT1NtBYg@mail.gmail.com>
Date: Mon, 20 Oct 2025 14:22:59 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: chenxiaosong.chenxiaosong@...ux.dev
Cc: stfrench@...rosoft.com, metze@...ba.org, pali@...nel.org, 
	smfrench@...il.com, sfrench@...ba.org, senozhatsky@...omium.org, 
	tom@...pey.com, pc@...guebit.org, ronniesahlberg@...il.com, 
	sprasad@...rosoft.com, bharathsm@...rosoft.com, christophe.jaillet@...adoo.fr, 
	linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 12/22] smb: move some duplicate definitions to common/cifspdu.h

On Tue, Oct 14, 2025 at 4:30 PM <chenxiaosong.chenxiaosong@...ux.dev> wrote:
>
> From: ChenXiaoSong <chenxiaosong@...inos.cn>
>
> In order to maintain the code more easily, move duplicate definitions to
> new common header file.
>
> Signed-off-by: ChenXiaoSong <chenxiaosong@...inos.cn>
> ---
>  fs/smb/client/cifspdu.h    | 153 +---------------------------------
>  fs/smb/common/cifspdu.h    | 165 +++++++++++++++++++++++++++++++++++++
>  fs/smb/server/smb_common.h |  80 +-----------------
>  3 files changed, 167 insertions(+), 231 deletions(-)
>  create mode 100644 fs/smb/common/cifspdu.h
>
> diff --git a/fs/smb/client/cifspdu.h b/fs/smb/client/cifspdu.h
> index c86a329e5822..9f42b0469d1a 100644
> --- a/fs/smb/client/cifspdu.h
> +++ b/fs/smb/client/cifspdu.h
> @@ -12,43 +12,10 @@
>  #include <net/sock.h>
>  #include <linux/unaligned.h>
>  #include "../common/smbfsctl.h"
> +#include "../common/cifspdu.h"
I prefer naming it smb1pdu.h.

>
>  #define CIFS_PROT   0
>  #define POSIX_PROT  (CIFS_PROT+1)
> -#define BAD_PROT 0xFFFF
Moving just this one doesn't look good.
Thanks.