linux-kernel - Re: [PATCH net] net: phy: micrel: always set shared->phydev for LAN8814

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17e75178-582f-495d-97fa-0868c79b7026@lunn.ch>
Date: Tue, 21 Oct 2025 15:32:57 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Robert Marko <robert.marko@...tura.hr>
Cc: daniel.machon@...rochip.com, hkallweit1@...il.com,
	linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, vadim.fedorenko@...ux.dev,
	horatiu.vultur@...rochip.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, luka.perkov@...tura.hr
Subject: Re: [PATCH net] net: phy: micrel: always set shared->phydev for
 LAN8814

On Tue, Oct 21, 2025 at 03:20:26PM +0200, Robert Marko wrote:
> Currently, during the LAN8814 PTP probe shared->phydev is only set if PTP
> clock gets actually set, otherwise the function will return before setting
> it.
> 
> This is an issue as shared->phydev is unconditionally being used when IRQ
> is being handled, especially in lan8814_gpio_process_cap and since it was
> not set it will cause a NULL pointer exception and crash the kernel.
> 
> So, simply always set shared->phydev to avoid the NULL pointer exception.
> 
> Fixes: b3f1a08fcf0d ("net: phy: micrel: Add support for PTP_PF_EXTTS for lan8814")
> Signed-off-by: Robert Marko <robert.marko@...tura.hr>

Please could you look at how this patch and

[PATCH net-next v2] net: phy: micrel: Add support for non PTP SKUs for lan8814

work together. It might be this patch is not required because of
changes in that patch?

Thanks
	Andrew